test(query-core): add test case for queryClient.isFetching #8720
Conversation
|
View your CI Pipeline Execution ↗ for commit 0bf7deb.
☁️ Nx Cloud last updated this comment at |
| queryFn: () => sleep(300).then(() => 'data'), | ||
| }) | ||
| expect(queryClient.isFetching()).toBe(1) | ||
| queryClient.prefetchQuery({ | ||
| queryKey: key2, | ||
| queryFn: () => sleep(200).then(() => 'data'), |
There was a problem hiding this comment.
since we use real timers per default, please keep those times short (5ms and 10ms at most), or use fake timers and advance them how you want.
There was a problem hiding this comment.
now that I think about it, we’re actually having problems with these kinds of tests, as they tend to be pretty flaky (see useIsFetching). The reason is probably batching, and how much power the machine has / how much work it has to do, so it appears often in CI that updates are batched together.
using fake timers is better (we have an example for that in the code-base somewhere, too)
I agree, thanks for feedback!👍 |
No description provided.