Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-query): fix type breaking when using useSuspenseQueries with spreaded queryOptions #8709

Merged
merged 2 commits into from
Feb 28, 2025
Merged

fix(react-query): fix type breaking when using useSuspenseQueries with spreaded queryOptions #8709

merged 2 commits into from
Feb 28, 2025
+45 −5

Conversation

gs18004
Copy link
Contributor

@gs18004 gs18004 commented Feb 26, 2025

closes #8708

The type error is not shown when we use useSuspenseQueries with spreaded queryOptions.
Also, the type of select function is inferred. (not working for dynamic arrays)

function myQueryOptions() {
    return queryOptions({
      queryKey: ['key1'],
      queryFn: () => 'Query Data',
    })
  }
  useSuspenseQueries({
    queries: [
      {
        ...myQueryOptions(),
        select(data: string) {
          return data
        },
      },
    ],
  })
}

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 26, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 2db1ebe.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 5s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 34s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-26 18:30:59 UTC

@gs18004 gs18004 changed the title fix(react-query): fix type breaking when using useSuspenseQueries with spreaded queryOptions fix(react-query): fix type breaking when using spreaded queryOptions Feb 26, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 26, 2025

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8709

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8709

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8709

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8709

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8709

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8709

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8709

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8709

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8709

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8709

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8709

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8709

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8709

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8709

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8709

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8709

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8709

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8709

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8709

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8709

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8709

commit: 2db1ebe

@codecov Codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.05%. Comparing base (74db582) to head (2db1ebe).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8709       +/-   ##
===========================================
+ Coverage   46.28%   84.05%   +37.76%     
===========================================
  Files         199       26      -173     
  Lines        7549      370     -7179     
  Branches     1733      109     -1624     
===========================================
- Hits         3494      311     -3183     
+ Misses       3675       50     -3625     
+ Partials      380        9      -371
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query 95.37% <100.00%> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@gs18004 gs18004 changed the title fix(react-query): fix type breaking when using spreaded queryOptions fix(react-query): fix type breaking when using useSuspenseQueries with spreaded queryOptions Feb 26, 2025
@TkDodo TkDodo merged commit ac4c56c into TanStack:main Feb 28, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

type breaks when using useSuspenseQueries with spreaded queryOptions
2 participants
@gs18004 @TkDodo