Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useSuspenseQuery: throw select errors #8593

Merged
merged 1 commit into from
Jan 28, 2025
Merged

useSuspenseQuery: throw select errors #8593

merged 1 commit into from
Jan 28, 2025

Conversation

OliverJAsh
Copy link
Contributor

@OliverJAsh OliverJAsh commented Jan 27, 2025 •
edited
Loading

Fixes #8591.

@OliverJAsh OliverJAsh mentioned this pull request Jan 27, 2025
Closed
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 27, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 592b1c3.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 41s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-27 21:08:49 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 27, 2025 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8593

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8593

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8593

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8593

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8593

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8593

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8593

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8593

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8593

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8593

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8593

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8593

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8593

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8593

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8593

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8593

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8593

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8593

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8593

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8593

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8593

commit: 592b1c3

@TkDodo
Copy link
Collaborator

TkDodo commented Jan 27, 2025

right, this destroys all scenarios without suspense, as error boundaries can also be used without suspense. We can only do this when suspense is set, so this needs an extra check.

@OliverJAsh
Copy link
Contributor Author

Thanks, I've pushed another change. The tests seem to pass now.

@codecov Codecov
Copy link

codecov bot commented Jan 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (2399bb0) to head (592b1c3).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8593       +/-   ##
===========================================
+ Coverage   46.28%   84.34%   +38.05%     
===========================================
  Files         199       26      -173     
  Lines        7538      364     -7174     
  Branches     1722      104     -1618     
===========================================
- Hits         3489      307     -3182     
+ Misses       3670       48     -3622     
+ Partials      379        9      -370
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query 95.95% <100.00%> (+0.01%) ⬆️
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit 088ec87 into TanStack:main Jan 28, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useSuspenseQuery types: data can be undefined
2 participants
@OliverJAsh @TkDodo