fix(angular-query): remove queryClient parameter from callback functions #8307
+46
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 834d96d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
arnoud-dv
force-pushed
the
fix/onsuccess-loses-type
branch
from
38181b8
to
834d96d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8307 +/- ##
===========================================
+ Coverage 45.96% 88.21% +42.24%
===========================================
Files 199 17 -182
Lines 7501 263 -7238
Branches 1717 40 -1677
===========================================
- Hits 3448 232 -3216
+ Misses 3676 30 -3646
+ Partials 377 1 -376
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The queryClient being passed to callback functions of injectMutation and injectQuery is convenient as there's no need for the developer to then inject the queryClient themselves. However it's causing problems with typing.
To get to a stable release removing this parameter for now.
This is a breaking change, if you currently use this functionality please inject the queryClient yourself:
class ComponentOrService { + queryClient = inject(QueryClient) - mutation = injectMutation((queryClient) => { - queryClient.setQueryData(['todos'], (old) => [...old, optimisticTodo]) + mutation = injectMutation(() => { + this.queryClient.setQueryData(['todos'], (old) => [...old, optimisticTodo]) }) }Fixes #8042