Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-query): do not overwrite staleTime with the suspense default value if it's a function #8174

Merged
merged 3 commits into from
Oct 13, 2024
Merged

fix(react-query): do not overwrite staleTime with the suspense default value if it's a function #8174

merged 3 commits into from
Oct 13, 2024

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Oct 13, 2024

fixes #8172

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 13, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2b3b8fa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 13, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8174

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8174

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8174

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8174

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8174

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8174

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8174

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8174

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8174

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8174

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8174

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8174

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8174

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8174

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8174

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8174

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8174

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8174

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8174

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8174

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8174

commit: 2b3b8fa

@codecov Codecov
Copy link

codecov bot commented Oct 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.84%. Comparing base (2fe16e5) to head (2b3b8fa).
Report is 33 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8174       +/-   ##
===========================================
+ Coverage   45.41%   81.84%   +36.43%     
===========================================
  Files         200       26      -174     
  Lines        7456      358     -7098     
  Branches     1696       98     -1598     
===========================================
- Hits         3386      293     -3093     
+ Misses       3694       56     -3638     
+ Partials      376        9      -367
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query 93.10% <100.00%> (-0.03%) ⬇️
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit d409854 into main Oct 13, 2024
8 checks passed
@TkDodo TkDodo deleted the feature/staletime-function-suspense branch October 13, 2024 09:21
This was referenced Nov 7, 2024
Closed
Merged
Merged
@doperiddle doperiddle mentioned this pull request Nov 8, 2024
Merged
@snyk-io snyk-io bot mentioned this pull request Nov 9, 2024
Open
@muhammadahsanmirza muhammadahsanmirza mentioned this pull request Nov 10, 2024
Open
@JulianFl JulianFl mentioned this pull request Nov 10, 2024
Open
@DemonBarber1020 DemonBarber1020 mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useSuspenseQuery ignores staleTime functions
1 participant
@TkDodo