Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): error booleans shouldn't permanently be typed as false #7956

Merged
merged 4 commits into from
Aug 26, 2024
Merged

fix(types): error booleans shouldn't permanently be typed as false #7956

merged 4 commits into from
Aug 26, 2024

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Aug 26, 2024

fixes #7954

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 26, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e2948d3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 26, 2024 •
edited
Loading

commit: e2948d3

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7956

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@7956

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@7956

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@7956

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7956

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@7956

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@7956

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@7956

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@7956

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@7956

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@7956

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@7956

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@7956

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@7956

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@7956

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@7956

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@7956

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@7956

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@7956

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@7956

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@7956

Open in Stackblitz

More templates

@codecov Codecov
Copy link

codecov bot commented Aug 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.29%. Comparing base (8cf7e2f) to head (e2948d3).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #7956       +/-   ##
=========================================
+ Coverage      0   63.29%   +63.29%     
=========================================
  Files         0      127      +127     
  Lines         0     4536     +4536     
  Branches      0     1262     +1262     
=========================================
+ Hits          0     2871     +2871     
- Misses        0     1437     +1437     
- Partials      0      228      +228
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.58% <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 92.83% <ø> (∅)
@tanstack/query-devtools 5.24% <ø> (∅)
@tanstack/query-persist-client-core 57.73% <ø> (∅)
@tanstack/query-sync-storage-persister 82.50% <ø> (∅)
@tanstack/react-query 92.50% <ø> (∅)
@tanstack/react-query-devtools 10.71% <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (∅)
@tanstack/solid-query 78.20% <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (∅)
@tanstack/svelte-query 87.33% <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (∅)
@tanstack/vue-query 71.42% <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit b93941d into main Aug 26, 2024
8 checks passed
@TkDodo TkDodo deleted the feature/refetch-boolean-types branch August 26, 2024 17:52
This was referenced Sep 17, 2024
Merged
Merged
Merged
@thaiduy0282 thaiduy0282 mentioned this pull request Sep 17, 2024
Open
@sebastien-comeau sebastien-comeau mentioned this pull request Sep 17, 2024
Closed
@ypreiser ypreiser mentioned this pull request Sep 17, 2024
Merged
@DimitriRomano DimitriRomano mentioned this pull request Sep 17, 2024
Open
@thaiduy0282 thaiduy0282 mentioned this pull request Sep 18, 2024
Open
@danial117 danial117 mentioned this pull request Sep 18, 2024
Open
@OATEF4313 OATEF4313 mentioned this pull request Sep 18, 2024
Open
@danial117 danial117 mentioned this pull request Sep 19, 2024
Open
@thaiduy0282 thaiduy0282 mentioned this pull request Sep 19, 2024
Open
@danial117 danial117 mentioned this pull request Sep 20, 2024
Open
@DimitriRomano DimitriRomano mentioned this pull request Sep 20, 2024
Open
This was referenced Sep 21, 2024
Merged
Merged
@CalPinSW CalPinSW mentioned this pull request Sep 21, 2024
Merged
@zntb zntb mentioned this pull request Sep 21, 2024
Closed
@ypreiser ypreiser mentioned this pull request Sep 21, 2024
Merged
@DimitriRomano DimitriRomano mentioned this pull request Sep 21, 2024
Open
@zntb zntb mentioned this pull request Sep 22, 2024
Merged
@DimitriRomano DimitriRomano mentioned this pull request Sep 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: query-core package: react-query package: solid-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite queries type issue for isFetchNextPageError
1 participant
@TkDodo