Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): initialData function that returns undefined should still discriminate after isSuccess check #5869

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Aug 15, 2023

closes #5870

@vercel
Copy link

vercel bot commented Aug 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
query ⬜️ Ignored (Inspect) Aug 15, 2023 7:13am

@nx-cloud
Copy link

nx-cloud bot commented Aug 15, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f02e8c2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f02e8c2:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +4.69% 🎉

Comparison is base (047005e) 88.72% compared to head (f02e8c2) 93.41%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             beta    #5869      +/-   ##
==========================================
+ Coverage   88.72%   93.41%   +4.69%     
==========================================
  Files          75       20      -55     
  Lines        2403      243    -2160     
  Branches      623       53     -570     
==========================================
- Hits         2132      227    -1905     
+ Misses        225       15     -210     
+ Partials       46        1      -45     
Files Changed Coverage Δ
packages/react-query/src/queryOptions.ts 0.00% <ø> (ø)

... and 55 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TkDodo TkDodo merged commit 3a16867 into beta Aug 15, 2023
@TkDodo TkDodo deleted the feature/initialdata-undefined-function branch August 15, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants