Skip to content

fix: Add missing extensions to ESM imports #5751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lachlancollins merged 1 commit into from
Jul 20, 2023
Merged

fix: Add missing extensions to ESM imports #5751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
"cpy-cli": "^4.2.0",
"current-git-branch": "^1.1.0",
"esbuild": "^0.18.13",
"esbuild-plugin-file-path-extensions": "^1.0.0",
"eslint": "^8.34.0",
"eslint-config-prettier": "^8.8.0",
"eslint-import-resolver-typescript": "^3.5.5",
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-query/tsup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ import { defineConfig } from 'tsup'
import { legacyConfig } from '../../scripts/getTsupConfig.js'

export default defineConfig([
legacyConfig({ entry: ['src/*.ts', 'src/*.tsx'], bundle: true }),
legacyConfig({ entry: ['src/*.ts', 'src/*.tsx'] }),
])
8 changes: 8 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 4 additions & 6 deletions scripts/getTsupConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
// @ts-check

import { esbuildPluginFilePathExtensions } from 'esbuild-plugin-file-path-extensions'

/**
* @param {Object} opts - Options for building configurations.
* @param {string[]} opts.entry - The entry array.
* @param {boolean} [opts.bundle] - Whether to bundle the output.
* @returns {import('tsup').Options}
*/
export function modernConfig(opts) {
Expand All @@ -12,18 +13,16 @@ export function modernConfig(opts) {
format: ['cjs', 'esm'],
target: ['chrome91', 'firefox90', 'edge91', 'safari15', 'ios15', 'opera77'],
outDir: 'build/modern',
bundle: opts.bundle || false,
splitting: opts.bundle || false,
dts: true,
sourcemap: true,
clean: true,
esbuildPlugins: [esbuildPluginFilePathExtensions({ esmExtension: 'js' })],
}
}

/**
* @param {Object} opts - Options for building configurations.
* @param {string[]} opts.entry - The entry array.
* @param {boolean} [opts.bundle] - Whether to bundle the output.
* @returns {import('tsup').Options}
*/
export function legacyConfig(opts) {
Expand All @@ -32,10 +31,9 @@ export function legacyConfig(opts) {
format: ['cjs', 'esm'],
target: ['es2020', 'node16'],
outDir: 'build/legacy',
bundle: opts.bundle || false,
splitting: opts.bundle || false,
dts: true,
sourcemap: true,
clean: true,
esbuildPlugins: [esbuildPluginFilePathExtensions({ esmExtension: 'js' })],
}
}