test(vue-query/useQuery): move suspense regression tests into 'useQuery.test.ts' - #11250
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit a79d0fa
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version Preview10 package(s) bumped directly, 15 bumped as dependents. 🟨 Minor bumps
🟩 Patch bumps
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughSuspense tests moved from ChangesVue Query suspense coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change only reorganizes existing suspense regression tests without changing published code or test behavior, so no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Move the two
.suspense()regression tests added in #11249 from the standalonesuspense.test.tsinto the existingdescribe('suspense', ...)block inuseQuery.test.ts, and delete the now-empty separate file.This is safe because
src/__mocks__/useBaseQuery.tsisvi.fn(originImpl)— a spy wrapping the real implementation, not a stub.useQuery.test.ts'svi.mock('../useBaseQuery')therefore preserves real behavior; it only enables the file's other test (should properly execute query) to assert on call arguments. The suspense tests still exercise the realfetchOptimisticcode path inquery-core, same as before the move.Verified locally: reverting
fetchOptimisticinpackages/query-core/src/queryObserver.tsto its pre-#11036 form makes both moved tests time out, confirming they still test the real fix after relocation.No test behavior changes — this is a file-organization move only.
✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit
Bug Fixes
Tests