Skip to content

feat(experimental_createQueryPersister): removeItem if deserialize fails #10190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DamianOsipiuk merged 5 commits into from
Feb 28, 2026
Merged

feat(experimental_createQueryPersister): removeItem if deserialize fails #10190

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
100692f
removeItem if deserialize fails
rklomp Feb 26, 2026
8da1d1d
changeset
rklomp Feb 26, 2026
8271434
Use storageKeyPrefix
rklomp Feb 26, 2026
6e20934
Set storageKeyPrefix outside loop
rklomp Feb 26, 2026
2875eb1
changeset is patch
rklomp Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hungry-adults-count.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/query-persist-client-core': minor
Comment thread
rklomp marked this conversation as resolved.
Outdated
---

removeItem if deserialize fails
32 changes: 25 additions & 7 deletions packages/query-persist-client-core/src/createPersister.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,13 @@ export function experimental_createQueryPersister<TStorageValue = string>({
try {
const storedData = await storage.getItem(storageKey)
if (storedData) {
const persistedQuery = await deserialize(storedData)
let persistedQuery: PersistedQuery
try {
persistedQuery = await deserialize(storedData)
} catch {
await storage.removeItem(storageKey)
return
}

if (isExpiredOrBusted(persistedQuery)) {
await storage.removeItem(storageKey)
Expand Down Expand Up @@ -241,11 +247,17 @@ export function experimental_createQueryPersister<TStorageValue = string>({

async function persisterGc() {
if (storage?.entries) {
const storageKeyPrefix = `${prefix}-`
const entries = await storage.entries()
for (const [key, value] of entries) {
if (key.startsWith(prefix)) {
const persistedQuery = await deserialize(value)

if (key.startsWith(storageKeyPrefix)) {
let persistedQuery: PersistedQuery
try {
persistedQuery = await deserialize(value)
} catch {
await storage.removeItem(key)
continue
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
if (isExpiredOrBusted(persistedQuery)) {
await storage.removeItem(key)
}
Expand All @@ -265,11 +277,17 @@ export function experimental_createQueryPersister<TStorageValue = string>({
const { exact, queryKey } = filters

if (storage?.entries) {
const storageKeyPrefix = `${prefix}-`
const entries = await storage.entries()
for (const [key, value] of entries) {
if (key.startsWith(prefix)) {
const persistedQuery = await deserialize(value)

if (key.startsWith(storageKeyPrefix)) {
let persistedQuery: PersistedQuery
try {
persistedQuery = await deserialize(value)
} catch {
await storage.removeItem(key)
continue
}
if (isExpiredOrBusted(persistedQuery)) {
await storage.removeItem(key)
continue
Expand Down
Loading