Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove form-core type overrides from adapters #794

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

crutchcorn
Copy link
Member

Previously, we were patching the types of form-core in our framework adapters, which meant that any imports to @tanstack/form-core would technically not be correct. This PR fixes this by localizing these imports and making them more accurate.

Copy link

nx-cloud bot commented Jun 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6d3b66d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.73%. Comparing base (5473bb8) to head (6d3b66d).
Report is 13 commits behind head on main.

Files Patch % Lines
packages/solid-form/src/createForm.tsx 83.33% 2 Missing ⚠️
packages/vue-form/src/useForm.tsx 80.00% 2 Missing ⚠️
packages/react-form/src/createServerValidate.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
- Coverage   91.55%   84.73%   -6.83%     
==========================================
  Files          21        9      -12     
  Lines         900      131     -769     
  Branches      206        8     -198     
==========================================
- Hits          824      111     -713     
+ Misses         71       19      -52     
+ Partials        5        1       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crutchcorn crutchcorn merged commit 145e0a9 into main Jun 28, 2024
2 of 4 checks passed
@crutchcorn crutchcorn deleted the remove-core-overrides branch June 28, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant