Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Run ESLint on tests #793

Merged
merged 3 commits into from
Jun 29, 2024
Merged

tests: Run ESLint on tests #793

merged 3 commits into from
Jun 29, 2024

Conversation

lachlancollins
Copy link
Member

  • Updated tanstack/config to v0.9, which is a bit more lenient with certain rules (warns rather than errors)

Copy link

nx-cloud bot commented Jun 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0be8208. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@lachlancollins lachlancollins marked this pull request as draft June 28, 2024 23:59
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.57%. Comparing base (5473bb8) to head (7d0c423).
Report is 17 commits behind head on main.

Current head 7d0c423 differs from pull request most recent head 0be8208

Please upload reports for the commit 0be8208 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
+ Coverage   91.55%   91.57%   +0.01%     
==========================================
  Files          21       21              
  Lines         900      902       +2     
  Branches      206      205       -1     
==========================================
+ Hits          824      826       +2     
- Misses         71       72       +1     
+ Partials        5        4       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lachlancollins lachlancollins marked this pull request as ready for review June 29, 2024 21:26
@lachlancollins lachlancollins merged commit 3f1dbed into main Jun 29, 2024
2 checks passed
@lachlancollins lachlancollins deleted the lint-tests branch June 29, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant