Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove void keyword from code handlers and documentation #676

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Savageman
Copy link
Contributor

It seems they are many questions related to the usage of the void keyword, and it was suggested to raise a PR to remove them here: #484 (comment)

This is my 1st contribution, I attempted to follow the guidelines and specifically the Commit messages conventions

However I'm not familiar with the stack (pnpm / ts), so I'm trusting the CI to detect any issue. Please double-check carefully too :)

Copy link

nx-cloud bot commented Apr 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e1562f9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work, thanks!

@crutchcorn crutchcorn merged commit c0ee012 into TanStack:main Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants