Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extract path from nested arrays #658

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

Balastrong
Copy link
Member

Fixes #657

I added a few tests and used it on a local project to check if it was working

Copy link

nx-cloud bot commented Mar 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 049ee2b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.07%. Comparing base (17bf6b5) to head (049ee2b).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
+ Coverage   88.95%   89.07%   +0.11%     
==========================================
  Files          32       32              
  Lines         851      851              
  Branches      189      189              
==========================================
+ Hits          757      758       +1     
+ Misses         87       86       -1     
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crutchcorn crutchcorn merged commit 41207f3 into TanStack:main Mar 27, 2024
2 checks passed
@crutchcorn
Copy link
Member

Thanks for this!

@Balastrong Balastrong deleted the fix/nested-arrays-fields branch March 28, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Values in nested arrays do not get updated properly
3 participants