Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user input #402

Closed
wants to merge 5 commits into from
Closed

Fix user input #402

wants to merge 5 commits into from

Conversation

crutchcorn
Copy link
Member

This PR builds on top of this PR: #401, please merge it first

This PR (specifically, this commit: 2f7ec1d) aims to fix user input from it's original broken state.

It includes tests to validate the fix.

However, I'm not a huge fan of this fix, as it duplicates the method of setting a value between the Form and Field. I'd much rather either:

  • Add a listener to the form from the field that updates the field when the form is updated
  • Abstract that away into a computed item in @tanstack/store that allows us to do this consistently with derived state

@crutchcorn crutchcorn mentioned this pull request Jul 4, 2023
@tannerlinsley
Copy link
Collaborator

Happy to merge whatever you see fit. Just go for it Corbin!

@crutchcorn crutchcorn closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants