docs: Expand submission handling and validation documentation #1428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeCarbonator
force-pushed
the
docs-submission-handling
branch
from
b5c409d to
8fd0b76
Compare
Contributor
Author
|
Angular is quite something. I'm attempting to work through it, but if someone with more experience in it could port the two files I'd appreciate it |
LeCarbonator
changed the title
…nstack-form into docs-submission-handling
Pascalmh
reviewed
Apr 18, 2025
…nstack-form into docs-submission-handling
Contributor
|
I'm not too confident reviewing angular, since I've only had a brief experience with it. Perhaps @Pascalmh can confirm it's good if he's working with it. I'll message some of the other maintainers to see if they're able to have a look. But, great job on adding to the docs! |
Pascalmh
suggested changes
Apr 22, 2025
Contributor
|
@harry-whorlow @LeCarbonator I used to work with angular until about a year ago - it looks good and seems to follow the Angular Style Guide - but angular evolves quickly - so someone that is actively working with Angular should take another look if possible. |
Co-authored-by: Pascal Küsgen <[email protected]>
Contributor
|
Thanks for the submission @LeCarbonator, and @Pascalmh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to expand the submission handling page with the following:
Rewrite Submission meta to be clearer
Add nested fields in form -> field validation example
Add Standard Schema input vs. output scenario
Address parity problems between frameworks in
validation.mdandsubmission-handling.md[ ] LitThere are docs files that have higher priority than these ones for Lit, as the current documentation is lacking.Due to point 3, this is marked as draft. Let me know if there are improvements to be added into the uploaded react files.
Since I am only familiar with React, I will test run the code snippets of other frameworks, so they might take a bit of a while.
This PR closes #1430 when merged.