test: remove first level sleep in tests and use fake timers

TanStack · Jul 2, 2024 · f561cc2 · f561cc2
1 parent 0b38c3e
commit f561cc2
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 15 deletions.
diff --git a/packages/valibot-form-adapter/tests/FieldApi.spec.ts b/packages/valibot-form-adapter/tests/FieldApi.spec.ts
@@ -1,4 +1,4 @@
-import { describe, expect, it } from 'vitest'
+import { describe, expect, it, vi } from 'vitest'
 import { FieldApi, FormApi } from '@tanstack/form-core'
 import * as v from 'valibot'
 import { valibotValidator } from '../src/index'
@@ -61,6 +61,7 @@ describe('valibot field api', () => {
   })
 
   it('should run an onChangeAsync with string validation', async () => {
+    vi.useFakeTimers()
     const form = new FormApi({
       defaultValues: {
         name: '',
@@ -87,14 +88,15 @@ describe('valibot field api', () => {
 
     expect(field.getMeta().errors).toEqual([])
     field.setValue('a', { touch: true })
-    await sleep(10)
+    await vi.advanceTimersByTimeAsync(10)
     expect(field.getMeta().errors).toEqual(['Testing 123'])
     field.setValue('asdf', { touch: true })
-    await sleep(10)
+    await vi.advanceTimersByTimeAsync(10)
     expect(field.getMeta().errors).toEqual([])
   })
 
   it('should run an onChangeAsyc fn with valibot validation option enabled', async () => {
+    vi.useFakeTimers()
     const form = new FormApi({
       defaultValues: {
         name: '',
@@ -118,10 +120,10 @@ describe('valibot field api', () => {
 
     expect(field.getMeta().errors).toEqual([])
     field.setValue('a', { touch: true })
-    await sleep(10)
+    await vi.advanceTimersByTimeAsync(10)
     expect(field.getMeta().errors).toEqual(['Test'])
     field.setValue('asdf', { touch: true })
-    await sleep(10)
+    await vi.advanceTimersByTimeAsync(10)
     expect(field.getMeta().errors).toEqual([])
   })
 

diff --git a/packages/yup-form-adapter/tests/FieldApi.spec.ts b/packages/yup-form-adapter/tests/FieldApi.spec.ts
@@ -1,4 +1,4 @@
-import { describe, expect, it } from 'vitest'
+import { describe, expect, it, vi } from 'vitest'
 import { FieldApi, FormApi } from '@tanstack/form-core'
 import yup from 'yup'
 import { yupValidator } from '../src/index'
@@ -58,6 +58,7 @@ describe('yup field api', () => {
   })
 
   it('should run an onChangeAsync with z.string validation', async () => {
+    vi.useFakeTimers()
     const form = new FormApi({
       defaultValues: {
         name: '',
@@ -83,14 +84,15 @@ describe('yup field api', () => {
 
     expect(field.getMeta().errors).toEqual([])
     field.setValue('a', { touch: true })
-    await sleep(10)
+    await vi.advanceTimersByTimeAsync(10)
     expect(field.getMeta().errors).toEqual(['Testing 123'])
     field.setValue('asdf', { touch: true })
-    await sleep(10)
+    await vi.advanceTimersByTimeAsync(10)
     expect(field.getMeta().errors).toEqual([])
   })
 
   it('should run an onChangeAsyc fn with zod validation option enabled', async () => {
+    vi.useFakeTimers()
     const form = new FormApi({
       defaultValues: {
         name: '',
@@ -114,10 +116,10 @@ describe('yup field api', () => {
 
     expect(field.getMeta().errors).toEqual([])
     field.setValue('a', { touch: true })
-    await sleep(10)
+    await vi.advanceTimersByTimeAsync(10)
     expect(field.getMeta().errors).toEqual(['Test'])
     field.setValue('asdf', { touch: true })
-    await sleep(10)
+    await vi.advanceTimersByTimeAsync(10)
     expect(field.getMeta().errors).toEqual([])
   })
 

diff --git a/packages/zod-form-adapter/tests/FieldApi.spec.ts b/packages/zod-form-adapter/tests/FieldApi.spec.ts
@@ -1,4 +1,4 @@
-import { describe, expect, it } from 'vitest'
+import { describe, expect, it, vi } from 'vitest'
 
 import { FieldApi, FormApi } from '@tanstack/form-core'
 import { z } from 'zod'
@@ -59,6 +59,7 @@ describe('zod field api', () => {
   })
 
   it('should run an onChangeAsync with z.string validation', async () => {
+    vi.useFakeTimers()
     const form = new FormApi({
       defaultValues: {
         name: '',
@@ -87,14 +88,15 @@ describe('zod field api', () => {
 
     expect(field.getMeta().errors).toEqual([])
     field.setValue('a', { touch: true })
-    await sleep(10)
+    await vi.advanceTimersByTimeAsync(10)
     expect(field.getMeta().errors).toEqual(['Testing 123'])
     field.setValue('asdf', { touch: true })
-    await sleep(10)
+    await vi.advanceTimersByTimeAsync(10)
     expect(field.getMeta().errors).toEqual([])
   })
 
   it('should run an onChangeAsyc fn with zod validation option enabled', async () => {
+    vi.useFakeTimers()
     const form = new FormApi({
       defaultValues: {
         name: '',
@@ -118,10 +120,10 @@ describe('zod field api', () => {
 
     expect(field.getMeta().errors).toEqual([])
     field.setValue('a', { touch: true })
-    await sleep(10)
+    await vi.advanceTimersByTimeAsync(10)
     expect(field.getMeta().errors).toEqual(['Test'])
     field.setValue('asdf', { touch: true })
-    await sleep(10)
+    await vi.advanceTimersByTimeAsync(10)
     expect(field.getMeta().errors).toEqual([])
   })