fix(forms): change perf issue (skipped char on IE)#524
Merged
jsomsanith-tlnd merged 22 commits intomasterfrom Jun 13, 2017
Merged
fix(forms): change perf issue (skipped char on IE)#524jsomsanith-tlnd merged 22 commits intomasterfrom
jsomsanith-tlnd merged 22 commits intomasterfrom
Conversation
Collaborator
Contributor
Author
|
This need to be tested on all app using form in order to make sure that's there's no regression. |
Collaborator
Collaborator
jare-talend
approved these changes
Jun 12, 2017
Collaborator
Collaborator
jsomsanith-tlnd
changed the title
jsomsanith-tlnd
changed the title
jsomsanith-tlnd
approved these changes
Jun 12, 2017
Collaborator
Contributor
There was a problem hiding this comment.
il works better except from 'Large' case of the storybook example. It is very slow when typing. It seems to be known issues (https://jira.talendforge.org/browse/TDS-2211)
Contributor
Author
|
@charlesnguyen sorry charles, thought you were talking about performance issue on the list component which is related to the known issue TDS-2211 indeed. |
Contributor
Author
|
seems to work fine on dqsee. |
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
Performance issue with object and array field managing state
rjsf-team/react-jsonschema-form#339
What is the chosen solution to this problem?
Make them stateless, an easier solution would have been to upgrade react-jsonschema-form version, but the 0.43 which contains the rework brings some breaking changes. And in addition of that, we also have some custom code in those files.
Report rjsf-team/react-jsonschema-form#480 on our ObjectField and ArrayField.
Please check if the PR fulfills these requirements
[ ] This PR introduces a breaking change