Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TCOMP-2620): oss build #924

Merged
merged 5 commits into from
Sep 5, 2024
Merged

feat(TCOMP-2620): oss build #924

merged 5 commits into from
Sep 5, 2024

Conversation

undx
Copy link
Member

@undx undx commented Sep 3, 2024

@undx undx changed the title Undx/tcomp 2620 oss build feat(TCOMP-2620): oss build Sep 3, 2024
@@ -1545,7 +1543,7 @@
</module>
<module name="UpperEll"/>
<module name="ImportOrder">
<property name="groups" value="*,java,javafx,javax,jdk,com,crawlercommons,org,orgomg,brave,com.jcraft,freemarker,io,zipkin2,lombok"/>
<property name="groups" value="*,java,javafx,javax,jdk,com,crawlercommons,org,orgomg,brave,com.jcraft,freemarker,io,zipkin2,routines,lombok"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we have it a separate checkstyle.xml file, like we have for connectors?

Copy link
Contributor

@ozhelezniak-talend ozhelezniak-talend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ozhelezniak-talend ozhelezniak-talend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ozhelezniak-talend ozhelezniak-talend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@undx undx merged commit f493f7a into master Sep 5, 2024
5 checks passed
@undx undx deleted the undx/TCOMP-2620-oss-build branch September 5, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants