Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TCOMP-2059): upgrade talend-ui #904

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

feat(TCOMP-2059): upgrade talend-ui #904

wants to merge 40 commits into from

Conversation

undx
Copy link
Member

@undx undx commented Jun 26, 2024

@sonar-eks sonar-eks

This comment has been minimized.

Sign in to view
@sonar-eks sonar-eks

This comment has been minimized.

Sign in to view
@jmfrancois jmfrancois force-pushed the undx/TCOMP-2059-talend-ui-upgrade branch from c6cdea0 to 1096c21 Compare July 11, 2024 12:29
@sonar-eks sonar-eks

This comment has been minimized.

Sign in to view
@undx
Merge branch 'master' into undx/TCOMP-2059-talend-ui-upgrade
f31d576 
# Conflicts:
#	documentation/src/main/java/org/talend/runtime/documentation/Generator.java
#	pom.xml
@sonar-eks sonar-eks

This comment has been minimized.

Sign in to view
@sonar-eks sonar-eks

This comment has been minimized.

Sign in to view
1 similar comment
@sonar-eks sonar-eks

This comment has been minimized.

Sign in to view
@sonar-eks sonar-eks

This comment has been minimized.

Sign in to view
@sonar-eks sonar-eks

This comment has been minimized.

Sign in to view
ozhelezniak-talend
ozhelezniak-talend approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@ozhelezniak-talend ozhelezniak-talend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
it's not our code, we copy-pasted it, right?
Can we use a web-jar (npm package) or smth for those web files (if it's not really a part of component-runtime source code)

@undx
Copy link
Member Author

undx commented Oct 11, 2024

LGTM it's not our code, we copy-pasted it, right? Can we use a web-jar (npm package) or smth for those web files (if it's not really a part of component-runtime source code)

No not a copy-paste job, we've some javascript frontend in the framework. So really part of component-runtime source code.

@sonar-eks sonar-eks

This comment has been minimized.

Sign in to view
@sonar-eks sonar-eks

This comment has been minimized.

Sign in to view
@sonar-eks sonar-eks

This comment has been minimized.

Sign in to view
1 similar comment
@sonar-eks sonar-eks
Copy link

sonar-eks bot commented Oct 14, 2024

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (0.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (1.30% Estimated after merge)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

@undx undx mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozhelezniak-talend ozhelezniak-talend ozhelezniak-talend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@undx @ozhelezniak-talend @mhuchet @jmfrancois