Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TDI-51172): [Security Scan]: remove Veracode SAST scan in all connector repository as we have now enabled GitHub Advanced Security #887

Merged
merged 1 commit into from
May 6, 2024

Conversation

wwang-talend
Copy link
Contributor

Requirements

  • Any code change adding any logic MUST be tested through a unit test executed with the default build
  • Any API addition MUST be done with a documentation update if relevant

Why this PR is needed?

https://jira.talendforge.org/browse/TDI-51172

What does this PR adds (design/code thoughts)?

https://jira.talendforge.org/browse/TDI-51172

connector repository as we have now enabled GitHub Advanced Security
Copy link
Contributor

@ozhelezniak-talend ozhelezniak-talend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonar-eks bot commented Apr 30, 2024

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (54.20% Estimated after merge)
  • Duplications No duplication information (1.30% Estimated after merge)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

Copy link
Member

@undx undx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wwang-talend wwang-talend merged commit ce60298 into master May 6, 2024
6 checks passed
@wwang-talend wwang-talend deleted the wwang-talend/TDI-51172-removesast branch May 6, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants