-
Notifications
You must be signed in to change notification settings - Fork 51
fix(TCOMP-2631): use URLDecoder.decode method #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
no test case to test it, advice to add if not complex to add case. |
- use StandardCharsets instead of string
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use a constant instead of string literal?
component-tools/src/main/java/org/talend/sdk/component/tools/exec/CarMain.java
Outdated
Show resolved
Hide resolved
component-tools/src/test/java/org/talend/sdk/component/tools/exec/CarMainTest.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Analysis Details0 IssuesCoverage and DuplicationsProject ID: org.talend.sdk.component:component-runtime |
(cherry picked from commit 8059898)
https://jira.talendforge.org/browse/TCOMP-2631