Skip to content

fix(TCOMP-2631): use URLDecoder.decode method #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

undx
Copy link
Member

@undx undx commented Feb 23, 2024

This comment has been minimized.

@wwang-talend
Copy link
Contributor

no test case to test it, advice to add if not complex to add case.

- use StandardCharsets instead of string

This comment has been minimized.

This comment has been minimized.

@undx undx requested a review from ozhelezniak-talend March 5, 2024 15:01

This comment has been minimized.

Copy link
Contributor

@ozhelezniak-talend ozhelezniak-talend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use a constant instead of string literal?

This comment has been minimized.

@ozhelezniak-talend ozhelezniak-talend self-requested a review March 6, 2024 14:56
Copy link
Contributor

@ozhelezniak-talend ozhelezniak-talend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonar-eks bot commented Mar 6, 2024

Failed

  • 0.00% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (54.20% Estimated after merge)
  • Duplications 0.00% Duplicated Code (1.30% Estimated after merge)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

@undx undx merged commit 8059898 into master Mar 18, 2024
5 of 6 checks passed
@undx undx deleted the undx/TCOMP-2631-carMain-decode branch March 18, 2024 15:29
undx added a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants