-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TCOMP-2598): theme icons support #851
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
...ent-server/src/main/java/org/talend/sdk/component/server/front/base/internal/RequestKey.java
Outdated
Show resolved
Hide resolved
...ent/component-server/src/main/java/org/talend/sdk/component/server/service/IconResolver.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose LGTM
But I leave a few comments
...ponent-server/src/main/java/org/talend/sdk/component/server/front/ComponentResourceImpl.java
Outdated
Show resolved
Hide resolved
...ponent-server/src/main/java/org/talend/sdk/component/server/front/ComponentResourceImpl.java
Show resolved
Hide resolved
...ponent-server/src/main/java/org/talend/sdk/component/server/front/ComponentResourceImpl.java
Show resolved
Hide resolved
...ponent-server/src/main/java/org/talend/sdk/component/server/front/ComponentResourceImpl.java
Show resolved
Hide resolved
...ent/component-server/src/main/java/org/talend/sdk/component/server/service/IconResolver.java
Outdated
Show resolved
Hide resolved
...ent/component-server/src/main/java/org/talend/sdk/component/server/service/IconResolver.java
Show resolved
Hide resolved
...nt-server/src/test/java/org/talend/sdk/component/server/front/ComponentResourceImplTest.java
Show resolved
Hide resolved
component-tools/src/main/java/org/talend/sdk/component/tools/ComponentValidator.java
Show resolved
Hide resolved
component-tools/src/main/java/org/talend/sdk/component/tools/ComponentValidator.java
Outdated
Show resolved
Hide resolved
...nd-component-maven-plugin/src/main/java/org/talend/sdk/component/maven/IconReporterMojo.java
Show resolved
Hide resolved
# Conflicts: # documentation/src/main/antora/modules/ROOT/pages/_partials/generated_rest-resources.adoc
This comment has been minimized.
This comment has been minimized.
Analysis Details1 IssueCoverage and DuplicationsProject ID: org.talend.sdk.component:component-runtime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question about the difference in pathes for legacy and themed icons.
component-tools/src/main/java/org/talend/sdk/component/tools/ComponentValidator.java
Show resolved
Hide resolved
component-tools/src/main/java/org/talend/sdk/component/tools/ComponentValidator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
https://jira.talendforge.org/browse/TCOMP-2598