-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TCOMP-2410) support document type #845
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 but a few comments.
We may need to handle document type in dynamic, this is not covered.
Check also Sonar errors and warnings, fix those possibles and mark the other as resolved.
...ent-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/record/DiRecordVisitor.java
Outdated
Show resolved
Hide resolved
...ent-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/record/DiRecordVisitor.java
Outdated
Show resolved
Hide resolved
...ent-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/record/DiRecordVisitor.java
Outdated
Show resolved
Hide resolved
...ent-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/record/DiRecordVisitor.java
Outdated
Show resolved
Hide resolved
...ent-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/record/DiRecordVisitor.java
Show resolved
Hide resolved
...time-di/src/test/java/org/talend/sdk/component/runtime/di/record/DiRowStructVisitorTest.java
Outdated
Show resolved
Hide resolved
...runtime-di/src/test/java/org/talend/sdk/component/runtime/di/record/DiRecordVisitorTest.java
Outdated
Show resolved
Hide resolved
...time-di/src/test/java/org/talend/sdk/component/runtime/di/record/DiRowStructVisitorTest.java
Outdated
Show resolved
Hide resolved
...ponent-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/record/VisitorsTest.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
...ent-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/record/DiRecordVisitor.java
Show resolved
Hide resolved
...time-di/src/test/java/org/talend/sdk/component/runtime/di/record/DiRowStructVisitorTest.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see last comment remaining, otherwise lgtm.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Analysis Details0 IssuesCoverage and DuplicationsProject ID: org.talend.sdk.component:component-runtime |
https://jira.talendforge.org/browse/TCOMP-2410