Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TCOMP-2410) support document type #845

Merged
merged 23 commits into from
Jun 11, 2024

Conversation

yyin-talend
Copy link
Collaborator

@yyin-talend yyin-talend commented Jan 31, 2024

This comment has been minimized.

Copy link
Member

@undx undx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 but a few comments.
We may need to handle document type in dynamic, this is not covered.
Check also Sonar errors and warnings, fix those possibles and mark the other as resolved.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@acatoire acatoire changed the title Yyin/tcomp 2410 support document feat(TCOMP-2410) support document type May 28, 2024

This comment has been minimized.

1 similar comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

undx
undx previously approved these changes Jun 3, 2024
Copy link
Member

@undx undx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see last comment remaining, otherwise lgtm.

This comment has been minimized.

undx
undx previously approved these changes Jun 5, 2024

This comment has been minimized.

This comment has been minimized.

Copy link

sonar-eks bot commented Jun 7, 2024

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 90.91% Coverage (54.30% Estimated after merge)
  • Duplications 0.00% Duplicated Code (1.30% Estimated after merge)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

@acatoire acatoire requested a review from undx June 10, 2024 15:04
@yyin-talend yyin-talend merged commit 8705196 into master Jun 11, 2024
6 checks passed
@yyin-talend yyin-talend deleted the yyin/TCOMP-2410-supportDocument branch June 11, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants