Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only allow transaction amount that aligns with the database #167

Merged
merged 1 commit into from
Sep 29, 2024
Merged

only allow transaction amount that aligns with the database #167

merged 1 commit into from
Sep 29, 2024

Conversation

joh748
Copy link
Collaborator

@joh748 joh748 commented Sep 29, 2024

  • users can only input transaction amount that aligns with the database, Numeric(16,2)
  • When the value exceeds the range, an alert will pop up with instructions
    • no more than 14 integer part
    • no more than 2 decimal part
  • use BigInt so that the comparison does not lose precision

@joh748 joh748 added the enhancement New feature or request label Sep 29, 2024
@joh748 joh748 linked an issue Sep 29, 2024 that may be closed by this pull request
Transaction values should align with the database #166
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@joh748
Copy link
Collaborator Author

joh748 commented Sep 29, 2024

no indication of the valid range on the TransactionForm but alert messages provide any necessary instruction

llam280
llam280 approved these changes Sep 29, 2024
View reviewed changes
Copy link
Collaborator

@llam280 llam280 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@llam280 llam280 merged commit 19f1e6b into Taks0708:main Sep 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llam280 llam280 llam280 approved these changes

@chrisv09 chrisv09 Awaiting requested review from chrisv09

@LX6T LX6T Awaiting requested review from LX6T

@Ben-G-Man Ben-G-Man Awaiting requested review from Ben-G-Man

@tom1dev tom1dev Awaiting requested review from tom1dev

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transaction values should align with the database
2 participants
@joh748 @llam280