Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test comments #136

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Test comments #136

merged 2 commits into from
Aug 22, 2024

Conversation

ewang2003
Copy link
Collaborator

@ewang2003 ewang2003 commented Aug 22, 2024 •
edited
Loading

Added comments to all the test files.
Achieved 100% branch coverage.
closes #135

@ewang2003 ewang2003 self-assigned this Aug 22, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

Taks07
Taks07 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@Taks07 Taks07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. again, sonarcloud is failing cause of hardcoded credentials. since this is only for testing purposes, its fine

@Taks07 Taks07 merged commit 7f8e104 into Taks0708:main Aug 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taks07 Taks07 Taks07 approved these changes

Assignees

@ewang2003 ewang2003

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commenting test files
2 participants
@ewang2003 @Taks07