Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated code for node v4 compilation #1

Closed
wants to merge 1 commit into from
Closed

Conversation

ldiqual
Copy link

@ldiqual ldiqual commented Nov 6, 2015

@hulbert

Compiles on node v4.2.2.

Build instructions:

$ nvm install v4.2.2
$ nvm use v4.2.2
$ npm install node-gyp
$ ./node_modules/.bin/node-gyp configure
$ ./node_modules/.bin/node-gyp build

Major steps used to convert to node v4:

@hulbert
Copy link

hulbert commented Nov 6, 2015

@ldiqual awesome! Thanks for tackling this.

Most nan values were MaybeLocal instead of Local (which is kind of an optional -- see https://github.com/nodejs/nan/blob/master/doc/maybe_types.md#api_nan_maybe_local), force converted them to Local with ToLocalChecked() (unsafe).

Any risk on this change to things crashing?

@ldiqual
Copy link
Author

ldiqual commented Nov 6, 2015

@hulbert My guess is that the behavior doesn't change between then and now: if you can't get a local handle, then it crashes. The new behavior of nan makes it so you have to unwrap the optional, the previous behavior produced an "implicit" optional (which would fail with a null reference if used). That's only my guess, my v8 and c++ skills are really rusty.

Ultimately, we'll want the original author of the library to confirm this.

@jdsadow
Copy link

jdsadow commented Nov 30, 2015

@ldiqual @hulbert what's the status on this, guys?

@hulbert
Copy link

hulbert commented Nov 30, 2015

@jdsadow will discuss in Trello

@rregue
Copy link

rregue commented Jun 26, 2017

I think we should close this.

@rregue rregue closed this Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants