Skip to content

Fix tag search to not require wildcards #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CyanVoxel merged 3 commits into from
Sep 12, 2024
Merged

Fix tag search to not require wildcards #481

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33aa786
Fix tag search to not require wildcards
Tyrannicodin Sep 9, 2024
fcfd576
Add partial tag check to test_tag_search
Tyrannicodin Sep 11, 2024
da67f0a
chore: format with ruff
CyanVoxel Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tagstudio/src/core/library/alchemy/library.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,8 +429,8 @@ def search_tags(
if search.tag:
query = query.where(
or_(
Tag.name.ilike(search.tag),
Tag.shorthand.ilike(search.tag),
Tag.name.icontains(search.tag),
Tag.shorthand.icontains(search.tag),
)
)

Expand Down
4 changes: 4 additions & 0 deletions tagstudio/tests/test_library.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ def test_tag_search(library):
FilterState(tag=tag.name.upper()),
)

assert library.search_tags(
FilterState(tag=tag.name[2:-2])
)

assert not library.search_tags(
FilterState(tag=tag.name * 2),
)
Expand Down