Skip to content

Change "show file in explorer" to be different depending on the OS #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CyanVoxel merged 21 commits into from
Aug 31, 2024
Merged

Change "show file in explorer" to be different depending on the OS #370

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
723e070
Update video_player.py
Precontation Aug 21, 2024
40b7ce1
Update preview_panel.py
Precontation Aug 21, 2024
dd7041c
Update constants.py
Precontation Aug 21, 2024
0210b80
Update ts_qt.py
Precontation Aug 21, 2024
0f2f3c7
Update item_thumb.py
Precontation Aug 21, 2024
666ad4a
update "open file in explorer" to "open file in filesystem" for Linux
TheseAreTheGoodGames Aug 22, 2024
0ed41b3
Revert "Update ts_qt.py"
TheseAreTheGoodGames Aug 23, 2024
b571197
Revert "Update constants.py"
TheseAreTheGoodGames Aug 23, 2024
920910f
Update tagstudio/src/qt/widgets/item_thumb.py
Precontation Aug 23, 2024
894b2a6
Update tagstudio/src/qt/widgets/item_thumb.py
Precontation Aug 23, 2024
ee7f4f7
Update tagstudio/src/qt/widgets/item_thumb.py
Precontation Aug 23, 2024
a8d020f
Update item_thumb.py
Precontation Aug 23, 2024
9451bdd
Update preview_panel.py
Precontation Aug 23, 2024
7017e2f
Update video_player.py
Precontation Aug 23, 2024
b1c863e
Update item_thumb.py
Precontation Aug 25, 2024
7d67804
Update preview_panel.py
Precontation Aug 25, 2024
faef8c6
Update video_player.py
Precontation Aug 25, 2024
af4c0d1
thing
Aug 25, 2024
e460398
Revert "thing"
Aug 25, 2024
df8e8ee
Format using Ruff
Aug 25, 2024
dd4816d
made it so preview_panel.py uses self.open_explorer_action instead of…
Aug 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tagstudio/src/qt/widgets/item_thumb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import contextlib
import logging
import os
import platform
import time
import typing
from pathlib import Path
Expand Down Expand Up @@ -194,7 +195,15 @@ def __init__(
self.opener = FileOpenerHelper("")
open_file_action = QAction("Open file", self)
open_file_action.triggered.connect(self.opener.open_file)
open_explorer_action = QAction("Open file in explorer", self)

system = platform.system()
if system == "Darwin":
open_explorer_action = QAction("Reveal file in Finder", self)
Comment thread
Precontation marked this conversation as resolved.
Outdated
elif system == "Linux":
open_explorer_action = QAction("Open file in filesystem", self) # TODO: Rename to whatever the Linux explorer is
Comment thread
Precontation marked this conversation as resolved.
Outdated
else:
open_explorer_action = QAction("Open file in explorer", self)
Comment thread
Precontation marked this conversation as resolved.
Outdated

open_explorer_action.triggered.connect(self.opener.open_explorer)
self.thumb_button.addAction(open_file_action)
self.thumb_button.addAction(open_explorer_action)
Expand Down
11 changes: 10 additions & 1 deletion tagstudio/src/qt/widgets/preview_panel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import logging
from pathlib import Path
import platform
import time
import typing
from datetime import datetime as dt
Expand Down Expand Up @@ -83,7 +84,15 @@ def __init__(self, library: Library, driver: "QtDriver"):
image_layout.setContentsMargins(0, 0, 0, 0)

self.open_file_action = QAction("Open file", self)
self.open_explorer_action = QAction("Open file in explorer", self)

system = platform.system()

if system == "Darwin":
self.open_explorer_action = QAction("Reveal file in Finder", self)
elif system == "Linux":
self.open_explorer_action = QAction("Open file in filesystem", self) # TODO: Rename to whatever the Linux explorer is
else:
self.open_explorer_action = QAction("Open file in explorer", self)

self.preview_img = QPushButtonWrapper()
self.preview_img.setMinimumSize(*self.img_button_size)
Expand Down
11 changes: 10 additions & 1 deletion tagstudio/src/qt/widgets/video_player.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import logging

from pathlib import Path
import platform
import typing

from PySide6.QtCore import (
Expand Down Expand Up @@ -129,7 +130,15 @@ def __init__(self, driver: "QtDriver") -> None:

open_file_action = QAction("Open file", self)
open_file_action.triggered.connect(self.opener.open_file)
open_explorer_action = QAction("Open file in explorer", self)

system = platform.system()
if system == "Darwin":
open_explorer_action = QAction("Reveal file in Finder", self)
elif system == "Linux":
open_explorer_action = QAction("Open file in filesystem", self) # TODO: Rename to whatever the Linux explorer is
else:
open_explorer_action = QAction("Open file in explorer", self)

open_explorer_action.triggered.connect(self.opener.open_explorer)
self.addAction(open_file_action)
self.addAction(open_explorer_action)
Expand Down