Blender thumbnail support #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included support for rendering blender thumbnails
Add functions that get the thumbnail's data
CyanVoxel
added
Type: Enhancement
Thesacraft
reviewed
Jun 11, 2024
Changed where imports are according to feedback
Changed blender thumbnail function name to reduce ambiguity
Updated function name
Ruff format
Ruff format
CyanVoxel
requested changes
Jun 14, 2024
Member
CyanVoxel
left a comment
CyanVoxel
left a comment
There was a problem hiding this comment.
Great work on this, it's super exciting to have blend support! 😁
I've got some suggested changes commented above - mostly optimizations and cleanup. Also, I noticed you were running into issues with the image being flipped when it was exported from the blend_extract_thumb function. If you wanted, you could import PIL into that file and do the image flipping there, letting you export a PIL Image object instead of the image_buffer, x, y list. This would also clean up the image creation process on the thumb_renderer side of things.
CyanVoxel
added
Status: Changes Requested
Add .blend1, 2, 3 etc file support
Refactor to follow requested changes
More refactoring
Ruff format
Ruff format
CyanVoxel
added
Status: Review Needed
CyanVoxel
added
Status: Mergeable
CyanVoxel
approved these changes
Jul 3, 2024
Member
CyanVoxel
left a comment
CyanVoxel
left a comment
There was a problem hiding this comment.
Awesome work on this, thank you so much!! 😁
I'm marking this as ready to merge and will target the 9.4 branch. If any conflicts come up I'll fix those real quick.
CarterPillow
pushed a commit
to CarterPillow/TagStudio
that referenced
this pull request
Sep 7, 2024
* Update thumb_renderer.py Included support for rendering blender thumbnails * Add files via upload Add functions that get the thumbnail's data * Update thumb_renderer.py * Update blender_thumbnailer.py * Update thumb_renderer.py * Update thumb_renderer.py Changed where imports are according to feedback * Update thumb_renderer.py Changed blender thumbnail function name to reduce ambiguity * Update blender_thumbnailer.py Updated function name * Update blender_thumbnailer.py * Update blender_thumbnailer.py Ruff format * Update thumb_renderer.py Ruff format * Update constants.py Add .blend1, 2, 3 etc file support * Update blender_thumbnailer.py Refactor to follow requested changes * Update thumb_renderer.py More refactoring * Update blender_thumbnailer.py Ruff format * Update thumb_renderer.py Ruff format
CyanVoxel
added a commit
that referenced
this pull request
Sep 22, 2024
Ports the following thumbnail and related PRs from the `Alpha-v9.4` branch to `main` (v9.5+): - (#273) Blender thumbnail support - (#307) Add font thumbnail preview support - (#331) refactor: move type constants to new media classes - (#390) feat(ui): expanded thumbnail and preview features - (#370) ui: "open in explorer" action follows os name - (#373) feat(ui): preview support for source engine files - (#274) Refactor video_player.py (Fix #270) - (#430) feat(ui): show file creation/modified dates + restyle path label - (#471) fix(ui): use default audio icon if ffmpeg is absent - (#472) fix(ui): use birthtime for creation time on mac & win Co-Authored-By: Ethnogeny <[email protected]> Co-Authored-By: Theasacraft <[email protected]> Co-Authored-By: SupKittyMeow <[email protected]> Co-Authored-By: EJ Stinson <[email protected]> Co-Authored-By: Sean Krueger <[email protected]>
CyanVoxel
added a commit
that referenced
this pull request
Oct 7, 2024
* feat: port v9.4 thumbnail + related feats to v9.5 Ports the following thumbnail and related PRs from the `Alpha-v9.4` branch to `main` (v9.5+): - (#273) Blender thumbnail support - (#307) Add font thumbnail preview support - (#331) refactor: move type constants to new media classes - (#390) feat(ui): expanded thumbnail and preview features - (#370) ui: "open in explorer" action follows os name - (#373) feat(ui): preview support for source engine files - (#274) Refactor video_player.py (Fix #270) - (#430) feat(ui): show file creation/modified dates + restyle path label - (#471) fix(ui): use default audio icon if ffmpeg is absent - (#472) fix(ui): use birthtime for creation time on mac & win Co-Authored-By: Ethnogeny <[email protected]> Co-Authored-By: Theasacraft <[email protected]> Co-Authored-By: SupKittyMeow <[email protected]> Co-Authored-By: EJ Stinson <[email protected]> Co-Authored-By: Sean Krueger <[email protected]> * remove vscode exceptions from `.gitignore` * delete .vscode directory * style: format for `ruff check` * fix(tests): update `test_update_widgets_not_selected` test * remove Send2Trash dependency * refactor: use dataclass for MediaCateogry * refactor: use enums for UI colors * docs: add file docstring for silent_Popen * refactor: replace logger with structlog * use early return inside `ResourceManager.get()` * add `is_ext_in_category()` method to `MediaCategory` Add method to check if an extension is a member of a given MediaCategory. * style: fix docstring style, missing type hints, rename `afm` * fix: use structlog vars in logging * refactor: move platform-dependent strings to PlatformStrings * refactor: move `parents[2]` path to variable * fix: undo logger regressions --------- Co-authored-by: Ethnogeny <[email protected]> Co-authored-by: Theasacraft <[email protected]> Co-authored-by: SupKittyMeow <[email protected]> Co-authored-by: EJ Stinson <[email protected]> Co-authored-by: Sean Krueger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used code from Blender's source code for extracting thumbnail, modified it and added special entry for .blend in the thumbnail renderer, to then use those functions