Skip to content

Conversation

@CyanVoxel
Copy link
Member

Summary

Fix #1063 by swapping the parent and child ID logic in TAG_CHILDREN_QUERY to match that of TAG_CHILDREN_ID_QUERY which was changed in the TagParent swap in #998.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added this to the Alpha v9.5.4 milestone Aug 26, 2025
@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Priority: High An important issue requiring attention TagStudio: Tags Relating to the TagStudio tag system TagStudio: Search The TagStudio search engine labels Aug 26, 2025
@CyanVoxel CyanVoxel moved this to 🏓 Ready for Review in TagStudio Development Aug 26, 2025
Copy link
Collaborator

@Computerdores Computerdores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In hindsight, I should probably have added a note to the definition of tag_parents to fix this query when the naming is corrected there, oh well...

@CyanVoxel CyanVoxel merged commit 3a0da46 into main Aug 27, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from 🏓 Ready for Review to ✅ Done in TagStudio Development Aug 27, 2025
@CyanVoxel CyanVoxel deleted the fix-1063 branch August 27, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: High An important issue requiring attention TagStudio: Search The TagStudio search engine TagStudio: Tags Relating to the TagStudio tag system Type: Bug Something isn't working as intended

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[Bug]: Tag search returns parents, not children

3 participants