Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 0 as min/max adj feedback range #2544

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Allow 0 as min/max adj feedback range #2544

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3725d5a
Allow 0 as min/max adj feedback range
tienne-B Nov 29, 2024
109f097
Add validation for min <= max for feedback questions
tienne-B Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tabbycat/adjfeedback/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ class Meta:
def clean(self):
integer_scale = AdjudicatorFeedbackQuestion.ANSWER_TYPE_INTEGER_SCALE
if self.cleaned_data.get('answer_type') == integer_scale:
if not self.cleaned_data.get('min_value') or not self.cleaned_data.get('max_value'):
if self.cleaned_data.get('min_value') is None or self.cleaned_data.get('max_value') is None:
raise forms.ValidationError(_("Integer scales must have a minimum and maximum"))
if self.cleaned_data['max_value'] < self.cleaned_data['min_value']:
raise forms.ValidationError(_("Maximum value must be greater than the minimum"))
return self.cleaned_data


Expand Down