Skip to content

Commit

Permalink
llava : update surgery script to not remove tensors (ggerganov#5536)
Browse files Browse the repository at this point in the history
This commit updates the surgery script to not remove the tensors from the
model file. For this to work the `--skip-unknown` flag is added as an
argument to the convert.py script in README.md.

The motivation for this change is that the surgery script currently
removes the projector tensors from the model file. If the model was
checked out from a repository, the model file will have been updated
and have to be checked out again to reset this effect. If this can be
avoided I think it would be preferable.

I did not perform this change for BakLLaVA models as I am not sure
how that part works.
  • Loading branch information
danbev authored Feb 18, 2024
1 parent bd2d4e3 commit fc0c8d2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion examples/llava/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ python ./examples/llava/convert-image-encoder-to-gguf.py -m ../clip-vit-large-pa
5. Use `convert.py` to convert the LLaMA part of LLaVA to GGUF:

```sh
python ./convert.py ../llava-v1.5-7b
python ./convert.py ../llava-v1.5-7b --skip-unknown
```

Now both the LLaMA part and the image encoder is in the `llava-v1.5-7b` directory.
Expand Down
6 changes: 1 addition & 5 deletions examples/llava/llava-surgery.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@
projector = {name: checkpoint[name].float() for name in mm_tensors}
torch.save(projector, f"{args.model}/llava.projector")

# remove these tensors from the checkpoint and save it again
for name in mm_tensors:
del checkpoint[name]

# BakLLaVA models contain CLIP tensors in it
clip_tensors = [k for k, v in checkpoint.items() if k.startswith("model.vision_tower")]
if len(clip_tensors) > 0:
Expand All @@ -39,7 +35,7 @@
f.write("{}\n")


torch.save(checkpoint, path)
torch.save(checkpoint, path)

print("Done!")
print(f"Now you can convert {args.model} to a regular LLaMA GGUF file.")
Expand Down

0 comments on commit fc0c8d2

Please sign in to comment.