Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple package name from project name #8

Open
jdigger opened this issue Nov 17, 2015 · 1 comment
Open

Decouple package name from project name #8

jdigger opened this issue Nov 17, 2015 · 1 comment
Labels
enhancement ready

Comments

@jdigger
Copy link
Member

jdigger commented Nov 17, 2015

The plugin is using the project name (project.name) as the key to know what to look for in the server's list of packages so it can get the "project id" needed to give the "install" command to Sling. The name used by Package Manager is stored in the package's META-INF/vault/properties.xml "name" value and in the META-INF/vault/definition/.content.xml "name" value.

Need some way to decouple the project name and the Package Manager name to use.
@jdigger jdigger mentioned this issue Nov 17, 2015
Closed
@jdigger
Copy link
Member Author

jdigger commented Jan 12, 2016

There also is currently no way to specify as part of the project properties the package "group", so a number of the commands that search the list of packages can not use it as a criteria.

It could be derived from META-INF/vault/properties.xml or as part of GH-10.

@jdigger jdigger changed the title * is not currently on the server, so can not install Decouple package name from project name Jan 12, 2016
@jdigger jdigger added the ready label Jan 12, 2016
jdigger added a commit that referenced this issue Jan 18, 2016
@jdigger
RuntimePackageProperties.packageProperties now wants a PackageId
7eda6d4 
"packageProperties" accepts a Jackrabbit PackageId instead of just a String (the package name) in preparation for implementing GH-8

Changed PackageHelperSpec to extend from ProjectSpec instead of just Specification to let Netflix's Nebula handle more of the boilerplate for testing

Removed deprecated CqPackageHelper.getPackageInfo()
jdigger added a commit that referenced this issue Jan 18, 2016
@jdigger
RuntimePackageProperties.packageProperties now wants a PackageId
8f1aa50 
"packageProperties" accepts a Jackrabbit PackageId instead of just a String (the package name) in preparation for implementing GH-8

Changed PackageHelperSpec to extend from ProjectSpec instead of just Specification to let Netflix's Nebula handle more of the boilerplate for testing

Removed deprecated CqPackageHelper.getPackageInfo()
jdigger added a commit that referenced this issue Jan 20, 2016
@jdigger
RuntimePackageProperties.packageProperties now wants a PackageId
c5d36cf 
"packageProperties" accepts a Jackrabbit PackageId instead of just a String (the package name) in preparation for implementing GH-8

Changed PackageHelperSpec to extend from ProjectSpec instead of just Specification to let Netflix's Nebula handle more of the boilerplate for testing

Removed deprecated CqPackageHelper.getPackageInfo()
jdigger added a commit that referenced this issue Jan 21, 2016
@jdigger
RuntimePackageProperties.packageProperties now wants a PackageId
481b9b5 
"packageProperties" accepts a Jackrabbit PackageId instead of just a String (the package name) in preparation for implementing GH-8

Changed PackageHelperSpec to extend from ProjectSpec instead of just Specification to let Netflix's Nebula handle more of the boilerplate for testing

Removed deprecated CqPackageHelper.getPackageInfo()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdigger