API changes needed to run dev/gpu#14
Merged
Merged
Conversation
Marshall and Ed changed the API of some FMS routines; I used git cherry-pick to bring them into TURBO's version of FMS, and then used patch to bring the same diffs onto TIM.
4 tasks
Contributor
Author
|
Did we base our CI testing on what GFDL does with FMS? Because NOAA-GFDL/FMS#1849 was merged in about a month ago and updates their testing to a much more recent gcc stack; I wonder if we should do something similar (either in this PR, or in a separate PR and I can wait for it to hit |
Following the lead from NOAA-GFDL/FMS, switch to a gcc 15.1.0 container
Configure in this REPO was reporting checking for netcdf.h... yes checking for library containing nc_create... -lnetcdf configure: error: NetCDF must be built with HDF5. checking if netCDF was built with HDF5... no This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. While GFDL CI says checking for netcdf.h... yes checking for library containing nc_create... -lnetcdf checking if netCDF was built with HDF5... yes checking for ncdump... yes I'm not sure why configure can't find HDF5 on our end
exclude should be in line with conf-flag and input-flag, not matrix
I'm really bad at YAMLing
Also switched to consistent variable names with the GFDL yaml file to help with the diffs; I don't see how any of these changes will help netCDF find HDF5
We only want to test with CMake, since that is how we build the model
Contributor
Author
|
Note this is same Fortran changes as TURBO-ESM/FMS#5 |
johnmauff
approved these changes
May 12, 2026
Contributor
johnmauff
left a comment
johnmauff
left a comment
There was a problem hiding this comment.
@mnlevy1981, thanks for the PR. As it states in your comments, It looks like the same set of fortran modifications as in FMS 5.
Contributor
Author
|
@alperaltuntas Are you okay with these changes? This is the last in the group with TURBO-ESM/MOM6#20 and TURBO-ESM/FMS#5 to let us use the |
alperaltuntas
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Marshall and Ed changed the API of some FMS routines; I used git cherry-pick to bring them into TURBO's version of FMS, and then used patch to bring the same diffs onto TIM.
This PR supercedes #12
How Has This Been Tested?
I ran the version of MOM6 from TURBO-ESM/MOM6#20 with this version of TIM and verified that the double_gyre test case is bit-for-bit with what is currently available in turbo-stack. I also used turbo-stack to run the TIM infrastructure layer unit tests, and they all passed.
Checklist: