[SCAFFOLD] AMReX shim for PPM_reconstruction_x#22
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds TIM/AMReX dispatch support for the zonal PPM reconstruction path in MOM_continuity_PPM, including a C-interop bridge interface and a Fortran shim that can route execution to either the Fortran implementation or an AMReX implementation (plus optional capture/debug output).
Changes:
- Added a
bind(C)interface forturbotmp_ppm_reconstruction_x_bridgeand a new shimPPM_reconstruction_xthat selects between capture / AMReX / Fortran execution modes. - Updated
zonal_edge_thicknessto useRealArray_tcontainers for PPM reconstruction and copy results back to Fortran arrays. - Refactored the original
PPM_reconstruction_ximplementation intoPPM_reconstruction_x_fortranand switched the slope array to an allocatable array sized from container bounds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
johnmauff
changed the title
johnmauff
changed the title
alperaltuntas
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts PPM_reconstruction_x from MOM6-style Fortran to AMReX-style Fortran. The AMReX-style Fortran takes advantage of the RealArray_t array containers and the Box_t data structure to make it simpler to convert to AMReX. In addition, a Fortran shim for the function was created to allow different execution paths, one for data capture, one for execution by AMReX, in addition to the original Fortran version.