Skip to content

test(sm120): cover touched-page split - #1

Merged
TTThanos merged 1 commit into
TTThanos:dpsk_sm120_optimizationfrom
ormandj:contrib/pr32320-lint-regression-test
Jul 27, 2026
Merged

TTThanos merged 1 commit into
TTThanos:dpsk_sm120_optimizationfrom
ormandj:contrib/pr32320-lint-regression-test

Conversation

@ormandj

@ormandj ormandj commented Jul 27, 2026

Copy link
Copy Markdown

Small follow-up for sgl-project#32320.

  • Fixes the current isort failure.
  • Adds an SM120-gated regression test through the production _split_kv_pages_to_64 wrapper.
  • Preseeds the persistent split and mask buffers, then checks mask reset/marking, returned layout, byte-exact data and scale copies, alignment padding, and untouched pages.

Validation on RTX PRO 6000 Blackwell (SM120):

TestTouchedPageSplit.test_only_marked_pages_are_split
Ran 1 test in 0.549s
OK

Full test_flash_mla_backends.py
Ran 14 tests in 4.601s
OK (skipped=1)

Also passed py_compile, registered-test validation, Black 26.1.0, isort 7.0.0, Ruff 0.15.1, and git diff --check.

The only production-file change is import ordering.

Prepared with AI assistance.


CI States

Latest PR Test (Base): ⚠️ Run #30233501515
Latest PR Test (Extra): ⚠️ Run #30233501510

Exercise the production page-split wrapper on SM120 with preseeded persistent buffers. Verify mask reset and marking, returned layout, byte-exact data and scale copies, untouched pages, and alignment padding. Also apply the import ordering required by pre-commit.
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@TTThanos
TTThanos merged commit e0d36f4 into TTThanos:dpsk_sm120_optimization Jul 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants