Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra quotes around output parameter value #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TTRh
Copy link
Owner

@TTRh TTRh commented Jun 18, 2020

Ensure we do not insert extra single quotes when using
valueFrom: jqFilter to set the value of an output parameter for
resource templates.

When playing with jqFilter, the return value begins with double quotes and ends in double quotes, also followed by a newline: i.e., "parameter value"\n

Related PR : argoproj#1232

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

TTRh and others added 2 commits June 18, 2020 13:56
Ensure we do not insert extra single quotes when using
valueFrom: jqFilter to set the value of an output parameter for
resource templates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant