Miscellaneous improvements #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Helbig <[email protected]>
If the redirect_uri as given by the client already contained (escaped) query parameters or fragments, we previously ignored them and still appended a new query or fragment part. With this fix, we now append our return values to the existing parts, if necessary. Signed-off-by: Kai Helbig <[email protected]>
ostrya
force-pushed
the
miscellaneous-improvements
branch
from
27e81a2 to
3b3f2cc
Compare
Signed-off-by: Kai Helbig <[email protected]>
Instead of defining a list of resources to apply the roles to, the user can now define a list of default audiences to add. In a new, separate setting, the user can decide whether the roles given by the login shall be applied to the realm, all audiences (which double as resources), or both. This is a breaking API and behavior change! Signed-off-by: Kai Helbig <[email protected]>
Yes, I know that Keycloak proper has stopped serving the keycloak.js file. But since I want to stay somewhat backward-compatible regarding old Keycloak versions, I should still ensure correctness. Signed-off-by: Kai Helbig <[email protected]>
They have been deprecated for almost 4 years now. Let's drop them. Signed-off-by: Kai Helbig <[email protected]>
and UI improvements for login page Signed-off-by: Kai Helbig <[email protected]>
if you are still relying on the shipped js, you probably also want the old version, as v26 introduced some breaking changes Signed-off-by: Kai Helbig <[email protected]>
ostrya
force-pushed
the
miscellaneous-improvements
branch
from
3b3f2cc to
05fda28
Compare
as there's no useful way of testing this Signed-off-by: Kai Helbig <[email protected]>
ostrya
force-pushed
the
miscellaneous-improvements
branch
from
05fda28 to
9ac87bb
Compare
and add support for templated iframe Signed-off-by: Kai Helbig <[email protected]>
ostrya
force-pushed
the
miscellaneous-improvements
branch
from
4dc22d0 to
a737ad1
Compare
for #48 Signed-off-by: Kai Helbig <[email protected]>
ostrya
force-pushed
the
miscellaneous-improvements
branch
from
a737ad1 to
922c163
Compare
Signed-off-by: Kai Helbig <[email protected]>
|
ripssi
reviewed
Apr 4, 2025
| @@ -145,7 +191,8 @@ void oob_redirect_location_is_generated_correctly() { | |||
| String redirectLocation = uut.getRedirectLocation(session, urlConfiguration); | |||
|
|
|||
| assertThat(redirectLocation) | |||
| .isEqualTo("file:///oob-dummy?session_state=session123&state=state123&code=session123"); | |||
| // converting to URI and back to String seems to drop the superfluous //, but that's OK | |||
There was a problem hiding this comment.
Is the file protocol a relevant case for redirects? Otherwise the removal of "//" could make a difference ... Probably the parser does ignore the protocol or interprets it as the hostnname?
ripssi
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.