Add basic PlantUML support (feature request #78) #80

studix · 2021-05-24T08:49:04Z

ArchUnitNET.Domain.PlantUml:
new namespace which contains the PlantUML parser code ported from ArchUnit java
TypesShould / TypeConditionsDefinition:
contains new method AdhereToPlantUmlDiagram for PlantUML based dependency checks

ExampleArchUnitTestPuml demonstrates the feature

Changed LoadAssemblies() Test Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

…thods Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

…ic methods where not assigned correctly Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: Marco Studer <[email protected]>

…and Interface as input Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

…cyInMethodBodyTo() methods to accept more input parameters Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

create matching() method for SliceRules Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

…der on .net 3.1 Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

…n found cycles Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

…ies between slices Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

…e where counted Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: Marco Studer <[email protected]>

…d Fluent. fix minor issues Signed-off-by: Pavel Fischer <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: Pavel Fischer <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

…r generated MoveNext() method Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

…eated the same as in other methods Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

…d generator methods) Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: Sebastijan Mueller <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: smuel <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Signed-off-by: Marco Studer <[email protected]>

fgather · 2021-06-01T22:00:10Z

something bad happened :) The diff contains all Commits since some years, which makes it very hard to review. Do you know how this happened? Looks like you recommitted all the history, only with the original author?

fgathercoupa

Thank you! The code looks very clean to me and I only have a few remarks :)

fgathercoupa · 2021-06-01T22:11:40Z

ArchUnitNET/Domain/PlantUml/ComponentName.cs

+
+        public override int GetHashCode()
+        {
+            return -1939223833 + EqualityComparer<string>.Default.GetHashCode(_value);


how did you generate the equals/gethashcode methods? would it be possible to use the convention we have in other places?

Visual Studio 2019 generated that code. I will have a look at other equals methods and use that convention.

I can also do this. I assume we used Rider/Resharper

fgathercoupa · 2021-06-01T22:13:57Z

ArchUnitNET/Domain/PlantUml/PlantUmlDiagram.cs

+[assembly: InternalsVisibleTo("ArchUnitNETTests")]
+namespace ArchUnitNET.Domain.PlantUml
+{
+    internal class PlantUmlDiagram


should all those domain classes be internal? or could some be accessible to be used without the fluent api? Like most other domain classes

My intention was to encapsulate the whole parser code. This code should not be part of the libraries public API as it is an implementation detail.

ok, sounds reasonable. However, this somehow implies that this feature won't be able with the non-fluent API. which is fine, but maybe there is a nice way to enable it later.

fgathercoupa · 2021-06-01T22:20:03Z

ArchUnitNET/Domain/PlantUml/PlantUmlParser.cs

+    internal class PlantUmlParser
+    {
+        private PlantUmlPatterns _plantUmlPatterns = new PlantUmlPatterns();
+        public PlantUmlDiagram Parse(string filename)


we could additionally allow for streams. That could make it easier to test against architecture documentations, but more importantly: we could simplify some test code, which would not need to write files, but the test files could be inserted as an in memory stream

fgathercoupa · 2021-06-01T22:21:57Z

ArchUnitNETTests/Domain/PlantUml/TestDiagram.cs

+            return new TestDiagram(path);
+        }
+
+        public ComponentCreator Component(string componentName)


suggestion: rename to ComponentBuilder? That might improve consistency with other builders in the project

fgathercoupa · 2021-06-01T22:23:00Z

ExampleTest/Resources/shopping_example.puml

+import -left-> catalog : parse products
+import --> xml
+import --> [Customers]
+note top on link #lightgreen: is responsible for translating XML to java classes


Java? What is this :D

copy & paste

studix · 2021-06-02T05:33:20Z

fgathercoupa> something bad happened :) The diff contains all Commits since some years, which makes it very hard to review. Do you know how this happened? Looks like you recommitted all the history, only with the original author?

I initially forgot to add a signoff message to my commits. In the pull request a rebase command was suggested by github to fix this. Unfortunatly this command also added my signoff message to old commits. I would suggest to reject my pull request. I'm worried about that this will be merged also to the main branch when you accept the pull request. I could take over my changes to a new branch in my fork and create a new pull request. What do you think?

fgathercoupa · 2021-06-02T07:26:47Z

fgathercoupa> something bad happened :) The diff contains all Commits since some years, which makes it very hard to review. Do you know how this happened? Looks like you recommitted all the history, only with the original author?

I initially forgot to add a signoff message to my commits. In the pull request a rebase command was suggested by github to fix this. Unfortunatly this command also added my signoff message to old commits. I would suggest to reject my pull request. I'm worried about that this will be merged also to the main branch when you accept the pull request. I could take over my changes to a new branch in my fork and create a new pull request. What do you think?

Hi,
I won't merge it accidentally, but yes we should fix it. Maybe it is possible to cherry-pick your commits into a clean branch? And change the source branch to the new branch?

studix · 2021-06-02T18:30:43Z

fgathercoupa> something bad happened :) The diff contains all Commits since some years, which makes it very hard to review. Do you know how this happened? Looks like you recommitted all the history, only with the original author?
I initially forgot to add a signoff message to my commits. In the pull request a rebase command was suggested by github to fix this. Unfortunatly this command also added my signoff message to old commits. I would suggest to reject my pull request. I'm worried about that this will be merged also to the main branch when you accept the pull request. I could take over my changes to a new branch in my fork and create a new pull request. What do you think?

Hi,
I won't merge it accidentally, but yes we should fix it. Maybe it is possible to cherry-pick your commits into a clean branch? And change the source branch to the new branch?

What do you mean with "change the source branch to the new branch"?

studix · 2021-06-08T20:14:16Z

I would have a clean new branch ready on my fork. It also contains the changes from the review. Shall we delete this pull request and I will create a new one?

fgather · 2021-06-08T21:22:09Z

Hi, yes, that would be great, thank you! Best Regards

…

On Tue, Jun 8, 2021 at 10:14 PM Marco Studer ***@***.***> wrote: I would have a clean new branch ready on my fork. It also contains the changes from the review. Shall we delete this pull request and I will create a new one? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#80 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEV7UWJZKHO2RUI2GEF3WLTRZ22NANCNFSM45M2C4YA> .

studix · 2021-06-13T06:18:10Z

Pull request replaced by pull request #86

brandhuf and others added 30 commits May 24, 2021 21:39

Set Assembly Version automatically with Travis.

f60f3a6

Changed LoadAssemblies() Test Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

fixed wrong assignment of MethodCallDependencies to generic static me…

a4daca4

…thods Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

fixed another occurrence where MethodCallDependencies to generic stat…

662238a

…ic methods where not assigned correctly Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Reworded Readme

aa611ef

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Update LICENSE

adf8c73

Signed-off-by: Marco Studer <[email protected]>

Update README.md

13da822

Signed-off-by: Marco Studer <[email protected]>

added overload for fluent ImplementInterface() method to accept Type …

9393be2

…and Interface as input Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

added overloads for fluent Are(Not)CalledBy() and (DoNot)HaveDependen…

002bdab

…cyInMethodBodyTo() methods to accept more input parameters Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

update global.json to use .NET version 3.1.300

1c2a770

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

setup necessary classes for SliceRules

f8be778

create matching() method for SliceRules Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

implement cyclecheck

e36198a

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

implement tests for SliceRules

52e58a6

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

implement NotDependOnEachOther()

7f65faf

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

implement tests for NotDependOnEachOther()

6b59cde

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

revert sdk version to 2.2.207 to fix a bug with debugging tests in ri…

11726ce

…der on .net 3.1 Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

use strings as identifiers for Slices to prevent collisions

386ead1

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

code cleanup

975b416

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

fix typo

448aea8

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

create description for cycle detection which shows all dependencies i…

40d7fea

…n found cycles Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

create description for dependency detection which shows all dependenc…

43ca072

…ies between slices Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

only show unique dependencies in description of failed slice rules

1375d49

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

fix bug in NotDependOnEachOther() where dependencies to the same slic…

13c959c

…e where counted Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

set .net version to 2.2.402 to be the same as in Travis

5279a17

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

requested changes for Pull Request #15

36888d2

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Add renovate.json

f978cf7

Signed-off-by: Marco Studer <[email protected]>

create new namespace structure with mein namespaces Domain, Loader an…

f0f5dcd

…d Fluent. fix minor issues Signed-off-by: Pavel Fischer <[email protected]> Signed-off-by: Marco Studer <[email protected]>

update copyright and readme

106ed10

Signed-off-by: Pavel Fischer <[email protected]> Signed-off-by: Marco Studer <[email protected]>

split extension method to reduce incorrect dependencies

32c0d51

Signed-off-by: Pavel Fischer <[email protected]> Signed-off-by: Marco Studer <[email protected]>

fix example test

00713c0

Signed-off-by: Marco Studer <[email protected]>

fix another broken Assert.All assertion

ef32bd9

Signed-off-by: Marco Studer <[email protected]>

brandhuf and others added 20 commits May 24, 2021 21:41

use / instead of \\ in relative path to fix jarvis linux build

99ee171

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Update dependency nunit to v3.13.2

32a549e

Signed-off-by: Marco Studer <[email protected]>

add isIterator property to MethodMember

b54d7d2

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

get dependencies in method body of iterators by analyzing the compile…

51fc36f

…r generated MoveNext() method Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

tests for generators

b11f160

Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

test to ensure that references to static methods in generators are tr…

0e3e6d0

…eated the same as in other methods Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

also find dependencies in compiler generated generators (mainly neste…

3d3cd00

…d generator methods) Signed-off-by: Fritz Brandhuber <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Add extensions for MSTest V2 framework.

cf0d8af

Signed-off-by: Sebastijan Mueller <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Use .NET Core 2.2 instead of .NET 5.

036504c

Signed-off-by: Sebastijan Mueller <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Update MSTest to 2.2.3

9e5ff75

Signed-off-by: Sebastijan Mueller <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Correct package description.

512ff66

Signed-off-by: Sebastijan Mueller <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Adapt documentation and deploy script.

7fec40b

Signed-off-by: Sebastijan Mueller <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Update .NET Core 2.2 to .NET 5

ac5e123

Signed-off-by: smuel <[email protected]> Signed-off-by: Marco Studer <[email protected]>

Fix test and add record capabilities.

9f21a08

Signed-off-by: smuel <[email protected]> Signed-off-by: Marco Studer <[email protected]>

fix dependency parsing issue

a25b344

Signed-off-by: Marco Studer <[email protected]>

upgrade NET5 SDK version to 5.0.203

db472dc

Signed-off-by: Marco Studer <[email protected]>

add nuget.org explicitly

79553ce

Signed-off-by: Marco Studer <[email protected]>

fix deploy paths

3f6587d

Signed-off-by: Marco Studer <[email protected]>

rename package with namespace && remove .. syntax in tests

9cb5320

Signed-off-by: Marco Studer <[email protected]>

make example test succeed

0a13c4d

Signed-off-by: Marco Studer <[email protected]>

fgathercoupa suggested changes Jun 1, 2021

View reviewed changes

studix closed this Jun 13, 2021

studix deleted the puml branch June 13, 2021 06:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add basic PlantUML support (feature request #78) #80

Add basic PlantUML support (feature request #78) #80

studix commented May 24, 2021 •

edited

Loading

fgather commented Jun 1, 2021

fgathercoupa left a comment

fgathercoupa Jun 1, 2021

studix Jun 2, 2021

fgathercoupa Jun 2, 2021

fgathercoupa Jun 1, 2021

studix Jun 2, 2021 •

edited

Loading

fgathercoupa Jun 2, 2021

fgathercoupa Jun 1, 2021

studix Jun 2, 2021

fgathercoupa Jun 1, 2021

fgathercoupa Jun 1, 2021

studix Jun 2, 2021

studix commented Jun 2, 2021

fgathercoupa commented Jun 2, 2021

studix commented Jun 2, 2021

studix commented Jun 8, 2021

fgather commented Jun 8, 2021 via email

studix commented Jun 13, 2021

Add basic PlantUML support (feature request #78) #80

Add basic PlantUML support (feature request #78) #80

Conversation

studix commented May 24, 2021 • edited Loading

fgather commented Jun 1, 2021

fgathercoupa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

studix Jun 2, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

studix commented Jun 2, 2021

fgathercoupa commented Jun 2, 2021

studix commented Jun 2, 2021

studix commented Jun 8, 2021

fgather commented Jun 8, 2021 via email

studix commented Jun 13, 2021

studix commented May 24, 2021 •

edited

Loading

studix Jun 2, 2021 •

edited

Loading