Snap 3269#197

Merged

ahshahid merged 1830 commits intomasterfrom

Dec 15, 2019

This pull request is big! We're only showing the most recent 250 commits

Commits on Jul 8, 2017

[SNAP-846][CLUSTER] Ensuring that Uncaught exceptions are handled in the Snappy side and do not cause a system.exit (#2)

hbhanawat
authored and
Sumedh Wale
committed
[SNAPPYDATA] Updated Benchmark code from Spark PR#13899
Sumedh Wale
committed
[SNAPPYDATA] Spark version 2.0.1-2

Amogh Shetkar
authored and
Sumedh Wale
committed
[SNAPPYDATA] fixing antlr generated code for IDEA
Sumedh Wale
committed
[SNAP-1083] fix numBuckets handling (#15)
Sumedh Wale
committed
[SNAPPYDATA] MemoryStore changes for snappydata

rmishra
authored and
Sumedh Wale
committed
[SNAPPYDATA] Spark version 2.0.1-3

Amogh Shetkar
authored and
Sumedh Wale
committed
[SNAPPYDATA] Added SnappyData modification license

rmishra
authored and
Sumedh Wale
committed
[SNAPPYDATA] updating snappy-spark version after the merge
Sumedh Wale
committed
[SNAPPYDATA] Bootstrap perf (#16)

ahshahid
authored and
Sumedh Wale
committed
[SNAPPYDATA] Provide preferred location for each bucket-id in case of partitioned sample table. (#22)

Vivek Bhaskar
authored and
Sumedh Wale
committed
[SNAPPYDATA] Bumping version to 2.0.3-1
Sumedh Wale
committed
[SNAPPYDATA] Made two methods in Executor as protected to make them customizable for SnappyExecutors. (#26)

rishitesh
authored and
Sumedh Wale
committed
[SNAPPYDATA]: Honoring JAVA_HOME variable while compiling java files

Soubhik Chakraborty
authored and
Sumedh Wale
committed
[SNAPPYDATA] Helper classes for DataSerializable implementation. (#29)

Vivek Bhaskar
authored and
Sumedh Wale
committed
[SNAP-1192] correct offsetInBytes calculation (#30)
Sumedh Wale
committed
[SNAP-1198] Use ConcurrentHashMap instead of queue for ContextCleaner.referenceBuffer (#32)
Sumedh Wale
committed
[SNAP-1194] explicit addLong/longValue methods in SQLMetrics (#33)
Sumedh Wale
committed
[SNAPPYDATA] More optimizations to UTF8String
Sumedh Wale
committed
[SNAPPYDATA] Adding fixed stats to common filter expressions

Hemant Bhanawat
authored and
Sumedh Wale
committed
[SNAPPYDATA] adding kryo serialization missing in LongHashedRelation
Sumedh Wale
committed
[SNAPPYDATA] Correcting HashPartitioning interface to match apache spark
Sumedh Wale
committed
[SNAP-1233] clear InMemorySorter before calling its reset (#35)
Sumedh Wale
committed
[SNAPPYDATA] Adding more filter conditions for plan sizing as followup
Sumedh Wale
committed
[SNAPPYDATA] reduced factors in filters a bit to be more conservative
Sumedh Wale
committed
[SNAP-1240] Snappy monitoring dashboard (#36)

snappy-sachin
authored and
Sumedh Wale
committed
[SNAP-1251] Avoid exchange when number of shuffle partitions > child partitions (#37)
Sumedh Wale
committed
[SNAPPYDATA] reverting lazy val to def for defaultNumPreShufflePartitions
Sumedh Wale
committed
[SNAPPYDATA] Code changes for displaying product version details. (#38)

snappy-sachin
authored and
Sumedh Wale
committed
[SNAPPYDATA] Fixes for Scala Style precheckin failure. (#39)

snappy-sachin
authored and
Sumedh Wale
committed
[SNAPPYDATA] Removing duplicate RDD already in snappy-core
Sumedh Wale
committed
[SNAP-1256] (#41)

hbhanawat
authored and
Sumedh Wale
committed
SNAP-1257 (#40)

snappy-sachin
authored and
Sumedh Wale
committed
[SNAPPYDATA] Spark Version 2.0.3-2

Amogh Shetkar
authored and
Sumedh Wale
committed
SNAP-1281: UI does not show up if spark shell is run without snappydata (#42)

snappy-sachin
authored and
Sumedh Wale
committed
[SNAP-1185] Guard logging and time measurements (#28)
Sumedh Wale
committed
[SNAP-1136] Kryo closure serialtization support and optimizations (#27)
Sumedh Wale
committed
[SNAP-1190] Reduce partition message overhead from driver to executor (#31)
Sumedh Wale
committed
[SNAP-1202] Reduce serialization overheads of biggest contributors in queries (#34)
Sumedh Wale
committed
[SNAP-1067] Optimizations seen in perf analysis related to SnappyData PR#381 (#11)
Sumedh Wale
committed
[SNAP-1067] Optimizations seen in perf analysis related to SnappyData PR#381 (#11)
Sumedh Wale
committed
[SNAPPYDATA] Bootstrap perf (#16)

ahshahid
authored and
Sumedh Wale
committed
[SNAPPYDATA] Skip cast if non-nullable type is being inserted in nullable target
Sumedh Wale
committed
[SNAPPYDATA] optimized versions for a couple of string functions
Sumedh Wale
committed
[SNAPPYDATA] Update to gradle-scalatest version 0.13.1

Amogh Shetkar
authored and
Sumedh Wale
committed
Snap 982 (#43)

rishitesh
authored and
Sumedh Wale
committed
[SNAPPYDATA] Increasing the code generation cache eviction size to 300 from 100
Sumedh Wale
committed
[SNAP-1398] Update janino version to latest 3.0.x
Sumedh Wale
committed
[SNAPPYDATA] made some methods protected to be used by SnappyUnifiedManager (#47)

rishitesh
authored and
Sumedh Wale
committed
SNAP-1420

hbhanawat
authored and
Sumedh Wale
committed
[SNAPPYDATA] Reducing file read/write buffer sizes
Sumedh Wale
committed
[SNAP-1486] make QueryPlan.cleanArgs a transient lazy val (#51)
Sumedh Wale
committed
SNAP-1420 Review

hbhanawat
authored and
Sumedh Wale
committed
[SPARK-19500] [SQL] Fix off-by-one bug in BytesToBytesMap (#53)

rishitesh
authored and
Sumedh Wale
committed
SNAP-1545: Snappy Dashboard UI Revamping (#52)

snappy-sachin
authored and
Sumedh Wale
committed
[SNAPPYDATA] fixing scalastyle errors introduced in previous commits
Sumedh Wale
committed
SNAP-1698: Snappy Dashboard UI Enhancements (#55)

snappy-sachin
authored and
Sumedh Wale
committed
[SNAPPYDATA] reduce a byte copy reading from ColumnVector
Sumedh Wale
committed
[SNAPPYDATA] moved UTF8String.fromBuffer to Utils.stringFromBuffer
Sumedh Wale
committed
[SNAPPYDATA] handle "prepare" in answer comparison inside Map types too
Sumedh Wale
committed
[SNAPPYDATA] reverting changes to increase DECIMAL precision to 127
Sumedh Wale
committed
[SNAPPYDATA][MERGE-2.1] Some fixes after the merge

ymahajan
authored and
Sumedh Wale
committed
[SNAPPYDATA][MERGE-2.1]

ymahajan
authored and
Sumedh Wale
committed
[SNAPPYDATA][MERGE-2.1]

ymahajan
authored and
Sumedh Wale
committed
[SNAPPYDATA][MERGE-2.1]

ymahajan
authored and
Sumedh Wale
committed
[SNAPPYDATA][MERGE-2.1]

ymahajan
authored and
Sumedh Wale
committed

Commits on Jul 9, 2017

[SNAPPYDATA][MERGE-2.1] Missing patches and version changes
Sumedh Wale
committed

Commits on Jul 11, 2017

Commits on Jul 12, 2017

Fix from Hemant for fialing :docs target during precheckin run (#61)
Vivek Bhaskar
authored
SNAP-1794 (#59)
ymahajan
authored

Commits on Jul 18, 2017

[SNAP-1389] Optimized UTF8String.compareTo (#62)
Sumedh Wale
authored

Commits on Jul 22, 2017

[SNAPPYDATA][PERF] Fixes for issues found during concurrency testing (#63)
hbhanawat
authored

Commits on Jul 24, 2017

[SNAPPYDATA][PERF] optimized pattern matching for byte/time strings
Sumedh Wale
committed

Commits on Jul 25, 2017

SNAP-1792: Display snappy members logs on Snappy Pulse UI (#58)
snappy-sachin
authored

Commits on Jul 31, 2017

SNAP-1744: UI itself needs to consistently refer to itself as "SnappyData Pulse" (#64)
snappy-sachin
authored

Commits on Aug 8, 2017

Commits on Aug 9, 2017

Commits on Aug 15, 2017

Refactored the executor exception handling for cache (#71)
rishitesh
authored

Commits on Aug 16, 2017

[SNAP-1930] Rectified a code in WholeStageCodeGenRdd. (#73)
rishitesh
authored

Commits on Aug 17, 2017

Snap 1813 : Security - Add Server (Jetty web server) level user authentication for Web UI in SnappyData. (#72)
snappy-sachin
authored

Commits on Aug 18, 2017

Commits on Aug 19, 2017

[SNAPPYDATA] update janino to latest release 3.0.7
Sumedh Wale
committed

Commits on Aug 21, 2017

[SNAP-1951] move authentication handler bind to be inside connect (#75)
Sumedh Wale
authored

Commits on Aug 24, 2017

Bump version spark 2.1.1.1-rc1, store 1.5.6-rc1 and sparkJobserver 0.6.2.6-rc1
Amogh Shetkar
committed

Commits on Aug 30, 2017

Updated the year in the Snappydata copyright header. (#76)
kneeraj
authored
[SNAPPYDATA] upgrade netty versions (SPARK-18971, SPARK-18586)
Sumedh Wale
committed

Commits on Aug 31, 2017

Added code to dump generated code in case of exception (#77)
hbhanawat
authored

Commits on Sep 2, 2017

[SNAPPYDATA] more efficient passing of non-primitive literals
Sumedh Wale
committed

Commits on Sep 5, 2017

[SNAP-1993] Optimize UTF8String.contains (#78)
Sumedh Wale
authored

Commits on Sep 8, 2017

Version changed to reflect Release Candidate (RC)
Amogh Shetkar
committed

Commits on Sep 9, 2017

Fix to avoid dumping of gen code in case of low memory exception. (#79)
hbhanawat
authored

Commits on Sep 10, 2017

[SNAPPYDATA][AQP-293] Native JNI callback changes for UTF8String (#80)
Sumedh Wale
authored

Commits on Sep 11, 2017

[SNAPPYDATA] update jetty version
Sumedh Wale
committed

Commits on Sep 16, 2017

[SNAP-2033] pass the original number of buckets in table via OrderlessHashPartitioning (#82)
Sumedh Wale
committed

Commits on Sep 20, 2017

Update versions for snappydata 1.0.0, store 1.6.0, spark 2.1.1.1 and spark-jobserver 0.6.2.6
Amogh Shetkar
committed
[SNAPPYDATA] use common "vendorName" in build scripts
Sumedh Wale
committed

Commits on Oct 2, 2017

[SPARK-21967][CORE] org.apache.spark.unsafe.types.UTF8String#compareTo Should Compare 8 Bytes at a Time for Better Performance

original-brownbear
authored and
Sumedh Wale
committed

Commits on Oct 6, 2017

[SNAPPYDATA] relax access-level of Executor thread pools to protected
Sumedh Wale
committed

Commits on Oct 10, 2017

[SNAPPYDATA] Fix previous conflict in GenerateUnsafeProjection (#84)

jxwr
authored and
Sumedh Wale
committed
[SPARK-18586][BUILD] netty-3.8.0.Final.jar has vulnerability CVE-2014-3488 and CVE-2014-0193

srowen
authored and
Sumedh Wale
committed
[SPARK-18951] Upgrade com.thoughtworks.paranamer/paranamer to 2.6

yhuai
authored and
Sumedh Wale
committed
[SPARK-18971][CORE] Upgrade Netty to 4.0.43.Final

zsxwing
authored and
Sumedh Wale
committed
[SPARK-19409][BUILD] Bump parquet version to 1.8.2

dongjoon-hyun
authored and
Sumedh Wale
committed
[SPARK-19409][BUILD][TEST-MAVEN] Fix ParquetAvroCompatibilitySuite failure due to test dependency on avro

dongjoon-hyun
authored and
Sumedh Wale
committed
[SPARK-19411][SQL] Remove the metadata used to mark optional columns in merged Parquet schema for filter predicate pushdown

viirya
authored and
Sumedh Wale
committed
[SPARK-19409][SPARK-17213] Cleanup Parquet workarounds/hacks due to bugs of old Parquet versions

liancheng
authored and
Sumedh Wale
committed
[SPARK-20449][ML] Upgrade breeze version to 0.13.1

yanboliang
authored and
Sumedh Wale
committed
[SNAPPYDATA] version upgrades as per previous cherry-picks
Sumedh Wale
committed

Commits on Oct 23, 2017

Snap 2044 (#85)
rishitesh
authored

Commits on Oct 24, 2017

Snap 2061 (#83)
ahshahid
authored
[SNAPPYDATA] build changes/fixes (#81)
Sumedh Wale
authored
[SNAP-2061] fix scalastyle errors, add test
Sumedh Wale
committed

Commits on Nov 8, 2017

[SPARK-17788][SPARK-21033][SQL] fix the potential OOM in UnsafeExternalSorter and ShuffleExternalSorter

cloud-fan
authored and
Sumedh Wale
committed

Commits on Dec 7, 2017

[SNAPPYDATA] add missing jersey-hk2 dependency
Sumedh Wale
committed

Commits on Dec 26, 2017

[SNAPPYDATA][SNAP-2120] make codegen cache size configurable (#87)
Sumedh Wale
authored

Commits on Dec 28, 2017

Snap 2084 (#86)
rishitesh
authored

Commits on Jan 8, 2018

[SNAPPYDATA] some optimizations to ExecutionMemoryPool
Sumedh Wale
committed

Commits on Jan 27, 2018

[SNAP-2087] fix ArrayIndexOutOfBoundsException with JSON data
Sumedh Wale
committed

Commits on Jan 30, 2018

[SNAPPYDATA] fixing all failures in snappy-spark test suite
Sumedh Wale
committed

Commits on Jan 31, 2018

[SNAPPYDATA] fixing one remaining failure in gradle runs
Sumedh Wale
committed

Commits on Feb 12, 2018

Preserve the preferred location in MapPartitionRDD. (#92)
rishitesh
authored
* SnappyData Spark Version 2.1.1.2
Amogh Shetkar
committed

Commits on Feb 16, 2018

[SNAP-2218] honour timeout in netty RPC transfers (#93)
Sumedh Wale
authored

Commits on Feb 17, 2018

Check for null connection. (#94)
rishitesh
authored

Commits on Mar 3, 2018

[SNAPPYDATA] revert changes in Logging to upstream
Sumedh Wale
committed

Commits on Mar 7, 2018

[SNAPPYDATA] Changed TestSparkSession in test class APIs to base SparkSession
hemanthmeka
committed

Commits on Mar 8, 2018

[SNAPPYDATA] increased default codegen cache size to 2K
Sumedh Wale
committed

Commits on Mar 19, 2018

[SNAP-2225] Removed OrderlessHashPartitioning. (#95)
rishitesh
authored

Commits on Mar 21, 2018

[SNAP-2242] Unique application names & kill app by names (#98)
rishitesh
authored

Commits on Mar 22, 2018

[SNAPPYDATA] make Dataset.boundEnc as lazy val
Sumedh Wale
committed

Commits on May 17, 2018

fix for SNAP-2342 . enclosing with braces when the child plan of aggregate nodes are not simple relations or subquery aliases (#101)
ahshahid
authored

Commits on Jun 6, 2018

Snap 1334 : Auto Refresh feature for Dashboard UI (#99)
snappy-sachin
authored

Commits on Jun 18, 2018

Fixes for SNAP-2376: (#102)
snappy-sachin
authored

Commits on Jun 20, 2018

[SNAP-2379] App was getting registered with error (#103)
rishitesh
authored

Commits on Jun 28, 2018

Fixes for SNAP-2383: (#106)
snappy-sachin
authored

Commits on Jul 2, 2018

Handling of POJOs containg array of Pojos while creating data frames (#105)
ahshahid
authored

Commits on Jul 3, 2018

Spark compatibility (#107)
rishitesh
authored

Commits on Jul 6, 2018

Commits on Jul 9, 2018

Fixes for SNAP-2415: (#110)
snappy-sachin
authored

Commits on Jul 11, 2018

Fixing scala style issue.
rishitesh
committed

Commits on Jul 13, 2018

Commits on Jul 16, 2018

Commits on Jul 17, 2018

Fix to SNAP-2247 (#114)
kneeraj
authored

Commits on Jul 19, 2018

Fixes for SNAP-2437: (#115)
snappy-sachin
authored

Commits on Aug 3, 2018

Commits on Aug 7, 2018

[SNAPPYDATA] fixed scalastyle
Sumedh Wale
committed

Commits on Aug 8, 2018

* Version 2.1.1.3-RC1
Amogh Shetkar
committed

Commits on Aug 17, 2018

Commits on Aug 18, 2018

Commits on Sep 14, 2018

[SNAPPY-2511] initialize SortMergeJoin build-side scanner lazily (#124)
Sumedh Wale
authored
[SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and millisToDays fails w/java 8 181-b13

d80tb7
authored and
Sumedh Wale
committed

Commits on Sep 20, 2018

[SNAP-2569] remove explicit HiveSessionState dependencies
Sumedh Wale
committed

Commits on Oct 4, 2018

[SNAPPYDATA] make Benchmark class compatible with upstream
Sumedh Wale
committed

Commits on Oct 16, 2018

[SNAPPYDATA] fix default bind-address of ThriftCLIService
Sumedh Wale
committed

Commits on Oct 20, 2018

[SNAPPYDATA] generate spark-version-info.properties in source path
Sumedh Wale
committed

Commits on Oct 23, 2018

[SNAPPYDATA] Increase hive-thrift shell history file size to 50000 lines
Sumedh Wale
committed

Commits on Oct 26, 2018

[SNAPPYDATA] fix RDD info URLs to "Spark Cache"
Sumedh Wale
committed

Commits on Nov 1, 2018

[SNAPPYDATA] improved a gradle dependency to avoid unnecessary re-evaluation
Sumedh Wale
committed

Commits on Nov 4, 2018

Changed the year frim 2017 to 2018 in license headers.
Neeraj Kumar
committed

Commits on Nov 9, 2018

SNAP-2602 : On snappy UI, add column named "Overflown Size"/ "Disk Size" in Tables. (#127)
snappy-sachin
authored

Commits on Nov 14, 2018

Changes for SNAP-2612: (#126)
snappy-sachin
authored

Commits on Nov 29, 2018

SNAP-2661 : Provide Snappy UI User a control over Auto Update (#128)
snappy-sachin
authored

Commits on Dec 18, 2018

[SNAPPYDATA] Property to set if hive meta-store client should use isolated ClassLoader (#132)
Sumedh Wale
authored

Commits on Dec 20, 2018

[SNAP-2751] Enable connecting to secure SnappyData via Thrift server (#130)

ashetkar
authored and
ahshahid
committed

Commits on Dec 27, 2018

[SNAPPYDATA] update gradle to version 5.0
Sumedh Wale
committed

Commits on Dec 29, 2018

change javax.servlet-api version to 3.0.1
Sumedh Wale
committed

Commits on Jan 4, 2019

Updated the janino compiler version similar to upstream spark (#134)
PradeepSurale
authored

Commits on Jan 24, 2019

Commits on Feb 5, 2019

SNAP-2457 - enabling plan caching for hive thrift server sessions. (#139)
vatsalmevada
authored

Commits on Feb 20, 2019

Changes for SNAP-2926: (#142)
snappy-sachin
authored

Commits on Feb 22, 2019

Commits on Apr 4, 2019

Commits on Apr 8, 2019

Fixes for SNAP-2965: (#147)
snappy-sachin
authored

Commits on Apr 12, 2019

Commits on Apr 17, 2019

[SPARK-21523][ML] update breeze to 0.13.2 for an emergency bugfix in … (#149)
vatsalmevada
authored

Commits on Apr 18, 2019

Changes for SNAP-2974 : Snappy UI re-branding to TIBCO ComputeDB (#150)
snappy-sachin
authored

Commits on Apr 19, 2019

* Version changes
Amogh Shetkar
committed

Commits on Apr 29, 2019

Commits on May 3, 2019

Changes for SNAP-2989: (#152)
snappy-sachin
authored

Commits on May 7, 2019

[SNAPPYDATA] fix scalastyle error
Sumedh Wale
committed

Commits on Jun 5, 2019

Spark compatibility fixes (#153)
Sumedh Wale
authored

Commits on Jul 5, 2019

Considering jobserver class loader as a key for generated code cache - (#154)
vatsal mevada
authored

Commits on Jul 15, 2019

Commits on Jul 19, 2019

Tracking spark block manager directories for each executors and cleaning
Vatsal Mevada
committed

Commits on Jul 20, 2019

[SNAPPYDATA] fix scalastyle errors introduced by previous commit
Sumedh Wale
committed

Commits on Jul 22, 2019

Revert: Tracking spark block manager directories for each executors and cleaning them in next run if left orphan.
Vatsal Mevada
committed

Commits on Jul 24, 2019

allow for override of TestHive session
Sumedh Wale
committed

Commits on Jul 25, 2019

[SNAP-3010] Cleaning block manager directories if left orphan (#158)
vatsal mevada
authored

Commits on Jul 26, 2019

Commits on Jul 27, 2019

Test changes to allow clean override of TestHive (#164)
Sumedh Wale
authored
Fixing [SNAP-2653] (#159)
paresh-p11
authored
Added code changes for SNAP-2772 (#162)
smahajan05
authored
[SNAPPYDATA] fixing scalastyle errors
Sumedh Wale
committed

Commits on Jul 29, 2019

[SNAP-3103] - Cleaning orphan directories only for embedded mode (#165)
vatsal mevada
authored

Commits on Aug 2, 2019

Generate docs for built-in spark-supported sql functions (#166)
paresh-p11
authored

Commits on Aug 5, 2019

[SNAPPYDATA] add SnappyData builtin functions by reflection (#169)
Sumedh Wale
authored

Commits on Aug 8, 2019

Changes for SNAP-2604 & SNAP-3087: (#170)
snappy-sachin
authored

Commits on Aug 9, 2019

Commits on Aug 10, 2019

[SNAP-3111] honor spark.task.cpus as a local property (#167)
Sumedh Wale
authored

Commits on Aug 19, 2019

SNAP-2720: (#173)
snappy-sachin
authored

Commits on Aug 20, 2019

Header update 1.1.1 (#174)
ashetkar
authored

Commits on Sep 10, 2019

[SDENT-62] Making method synchronized as it is being invoked concurrently by two (#175)
vatsal mevada
authored

Commits on Sep 11, 2019

Adding code comment
Vatsal Mevada
committed

Commits on Oct 4, 2019

SNAP-2886 - executing streaming queries in separate scheduler pool when configured (#136)
vatsal mevada
authored

Commits on Oct 7, 2019

Fixing SNAP-3185 (#177)
paresh-p11
authored

Commits on Oct 19, 2019

[SNAP-3033] - Fixing a failing test in snappy compatibility suite (#178)
vatsal mevada
authored

Commits on Oct 23, 2019

[SNAP-3195] Making optimization related to constraint propagation optional (#179)
vatsal mevada
authored

Commits on Oct 24, 2019

Commits on Nov 8, 2019

[SPARK-24717][SS] Split out max retain version of state for memory in… (#183)
vatsal mevada
authored

Commits on Nov 16, 2019

Snap 3189 (#181)
smahajan05
authored

Commits on Nov 27, 2019

Snap 2919 : Implementation of Structured Streaming UI Tab (#184)
snappy-sachin
authored

Commits on Nov 28, 2019

Disabling the Structured Streaming UI feature for the time being.
snappy-sachin
committed

Commits on Nov 29, 2019

Commits on Dec 3, 2019

Commits on Dec 4, 2019

merging cherry picked commit 21fde57f15db974b710e7b00e72c744da7c1ac3c… (#188)
ahshahid
authored

Commits on Dec 6, 2019

Commits on Dec 8, 2019

Added change for initial metric name from TIBCO ComputeDB to TIBCO_Co… (#193)
smahajan05
authored

Commits on Dec 11, 2019

[SNAP 3268] Passing trigger interval as long value instead of entire Trigger object (#194)
vatsal mevada
authored

Commits on Dec 13, 2019

Commits on Dec 15, 2019

fixed two scala style errors
ahshahid
committed