fix(agent): abort timed-out SGLang requests via router workers - #2340
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
In the agentic rollout path, each agent turn sends a request to SGLang through the SGLang router. When a request is cancelled or hits the client-side read timeout, Slime must explicitly abort the corresponding SGLang request to release its scheduler slot and KV-cache resources.
Problem
sglang_urlpoints to the SGLang router address, but the router does not expose or forward the/abort_requestendpoint.The existing cleanup logic sends:
This request returns HTTP 404 and the exception is silently ignored. As a result, the original request may continue decoding on the worker even though the client has already timed out. The retry request can then be routed to another DP worker, causing the old request and the retry request to run concurrently.
This leads to:
Solution
This change adds a small helper,
_abort_sglang_request, inslime/agent/adapters/common.py.When a request is cancelled or times out:
/workersendpoint./abort_requestwith the original requestridto every worker concurrently.rid;abort_allis never used.Only the worker that owns the request will actually abort it. Requests with other IDs are not affected.
Scope
slime/agent/adapters/common.pyValidation
python3 -m py_compile slime/agent/adapters/common.pygit diff --checkridis sent to all backend workers