fix: improve compatibility with older SGLang versions - #2286
Merged
Merged
Conversation
ForAxel
force-pushed
the
dev/musa-patch-only
branch
from
August 20, 2026 06:28
39a3042 to
2224f01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve compatibility with SGLang releases that do not expose all of the argument aliases and router options expected by the latest Slime integration.
Changes
disable_health_checkonly when the installedsglang-routerexposes that option, preventing unsupported dynamic attributes from being forwarded to the native Router constructor.Motivation
SGLang argument and router APIs vary between releases. Slime previously assumed that at least one name in every argument alias pair and the
disable_health_checkrouter option were always available. With releases that do not provide those attributes, validation or router startup could fail before rollout initialization.The new capability checks preserve the existing behavior for versions that support these APIs and safely skip unavailable options for versions that do not.
Testing
Result:
20 passed.