Skip to content

fix: improve compatibility with older SGLang versions - #2286

Merged
zhuzilin merged 1 commit into
THUDM:mainfrom
ForAxel:dev/musa-patch-only
Aug 20, 2026
Merged

zhuzilin merged 1 commit into
THUDM:mainfrom
ForAxel:dev/musa-patch-only

Conversation

@ForAxel

@ForAxel ForAxel commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Improve compatibility with SGLang releases that do not expose all of the argument aliases and router options expected by the latest Slime integration.

Changes

  • Skip SGLang parallelism aliases when neither the current nor legacy argument name is available, while continuing to synchronize aliases that are provided by the installed SGLang version.
  • Set disable_health_check only when the installed sglang-router exposes that option, preventing unsupported dynamic attributes from being forwarded to the native Router constructor.

Motivation

SGLang argument and router APIs vary between releases. Slime previously assumed that at least one name in every argument alias pair and the disable_health_check router option were always available. With releases that do not provide those attributes, validation or router startup could fail before rollout initialization.

The new capability checks preserve the existing behavior for versions that support these APIs and safely skip unavailable options for versions that do not.

Testing

PYTHONPATH=. pytest -q tests/utils/test_sglang_arguments.py tests/test_megatron_argument_validation.py

Result: 20 passed.

@ForAxel
ForAxel force-pushed the dev/musa-patch-only branch from 39a3042 to 2224f01 Compare August 20, 2026 06:28
@zhuzilin
zhuzilin merged commit 1494c50 into THUDM:main Aug 20, 2026
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants