fix(update_weight): bracket IPv6 master address in tcp:// init_method - #2151
Merged
zhuzilin merged 1 commit intoJul 1, 2026
Merged
Conversation
torch.distributed's tcp:// rendezvous requires IPv6 literals to be wrapped in brackets, e.g. tcp://[::1]:29500. master_address here comes from ray._private.services.get_node_ip_address(), which on IPv6-only / dual-stack clusters returns a bare IPv6 address. Concatenating it directly produced a malformed URI like tcp://fe80::1:29500, causing the weight-update process group to fail to initialize. Wrap master_address with _wrap_ipv6() (no-op for IPv4 / hostnames, idempotent for already-bracketed input) so the init_method is well-formed under IPv6.
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torch.distributed tcp:// rendezvous requires bracketed IPv6. master_address from ray.get_node_ip_address() can be a bare IPv6 on IPv6/dual-stack clusters, yielding a malformed tcp://fe80::1:29500. Wrap with _wrap_ipv6() (no-op for IPv4/hostnames). Fixes weight-update process-group init under IPv6.