Skip to content

[fix] eval sample logging when sample is a list #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhuzilin merged 1 commit into from
Apr 16, 2026
Merged

[fix] eval sample logging when sample is a list #1836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions slime/rollout/sglang_rollout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,10 +573,11 @@ async def eval_rollout_single_dataset(
for coro in asyncio.as_completed(tasks):
sample = await coro
if do_print:
logged_sample = sample[0] if isinstance(sample, list) else sample
logger.info(
"eval_rollout_single_dataset example data: "
f"{[str(sample.prompt) + sample.response]} "
f"reward={sample.reward}"
f"{[str(logged_sample.prompt) + logged_sample.response]} "
f"reward={logged_sample.reward}"
)
do_print = False
if isinstance(sample, list):
Expand Down