Skip to content

fix: use semantic version comparison for PyTorch >= 2.6 detection #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhuzilin merged 1 commit into from
Mar 8, 2026
Merged

fix: use semantic version comparison for PyTorch >= 2.6 detection #1667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion slime/utils/distributed_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from typing import Any

import torch
from packaging.version import parse as V
import torch.distributed as dist
from torch.distributed.distributed_c10d import (
Backend,
Expand Down Expand Up @@ -74,7 +75,7 @@ def init_process_group(
# NOTE: The pg_options parameter was renamed into backend_options in PyTorch 2.6.0
# https://github.com/pytorch/pytorch/commit/a0c7029a75628cd5fa8df83c0de0ea98ee7fd844
# We need to determine the appropriate parameter name based on PyTorch version
pg_options_param_name = "backend_options" if str(torch.__version__) >= "2.6" else "pg_options"
pg_options_param_name = "backend_options" if V(torch.__version__) >= V("2.6") else "pg_options"
pg, _ = _new_process_group_helper(
world_size,
rank,
Expand Down