Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement logging for SegyFile #228

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Implement logging for SegyFile #228

merged 7 commits into from
Nov 20, 2024

Conversation

tasansal
Copy link
Contributor

Added logging and better exception handling for SegyFile overall.

Also improved test coverage with extended text header inference and override (while adding logging).

@tasansal tasansal added the enhancement New feature or request label Nov 20, 2024
@tasansal tasansal self-assigned this Nov 20, 2024
…message matching in tests. Introduced a clearer variable name for settings revision in `file.py`.
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 96.35036% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.28%. Comparing base (74fb864) to head (328b69a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/segy/file.py 93.15% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   95.20%   95.28%   +0.07%     
==========================================
  Files          48       48              
  Lines        2274     2355      +81     
  Branches      127      128       +1     
==========================================
+ Hits         2165     2244      +79     
- Misses         81       84       +3     
+ Partials       28       27       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Altay Sansal added 5 commits November 20, 2024 13:07
Consolidate revision detection code for SEG-Y <Rev2 into a single conditional block. Change log levels from info to debug for endianness actions to reduce log verbosity. Fix incorrect trace count logging by updating the variable used.
@tasansal tasansal merged commit e86d890 into main Nov 20, 2024
32 checks passed
@tasansal tasansal deleted the logging branch November 20, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant