Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SEG-Y endianness and spec inference more robust and flexible #223

Merged
merged 12 commits into from
Nov 19, 2024

Conversation

tasansal
Copy link
Contributor

@tasansal tasansal commented Nov 15, 2024

  • Ensure all revisions are parsed correctly pre/post 2.0
  • Ensure endianness parsing and overrides are robust
  • Re-write tests if necessary

@tasansal tasansal added the bug Something isn't working label Nov 15, 2024
@tasansal tasansal self-assigned this Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 94.48276% with 8 lines in your changes missing coverage. Please review.

Project coverage is 95.19%. Comparing base (ff7321d) to head (aa3f3d0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/segy/file.py 88.73% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   95.17%   95.19%   +0.02%     
==========================================
  Files          48       48              
  Lines        2195     2268      +73     
  Branches      263      128     -135     
==========================================
+ Hits         2089     2159      +70     
  Misses         81       81              
- Partials       25       28       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Altay Sansal added 10 commits November 18, 2024 15:57
The 'samples_per_trace' and 'sample_interval' fields were removed from `src/segy/config.py`. These fields are no longer needed and their removal simplifies the configuration handling.
Rework the logic for inferring the endianness and revision of SEG-Y files, introducing explicit handling for different cases and additional settings-based overrides. This update simplifies control flow and improves the clarity and maintainability of the code.
Extract spec initialization into a separate method `_initialize_spec` to simplify the code structure and improve readability. This refactoring ensures centralized logic for setting the SEG-Y standard and endianness, reducing redundancy and potential errors.
@tasansal tasansal merged commit b5885c9 into main Nov 19, 2024
31 of 32 checks passed
@tasansal tasansal deleted the robust-endianness branch November 19, 2024 23:30
@tasansal tasansal linked an issue Nov 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEG-Y Revision Parsing Incorrect
1 participant