-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SEG-Y endianness and spec inference more robust and flexible #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tasansal
commented
Nov 15, 2024
•
edited
Loading
edited
- Ensure all revisions are parsed correctly pre/post 2.0
- Ensure endianness parsing and overrides are robust
- Re-write tests if necessary
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
==========================================
+ Coverage 95.17% 95.19% +0.02%
==========================================
Files 48 48
Lines 2195 2268 +73
Branches 263 128 -135
==========================================
+ Hits 2089 2159 +70
Misses 81 81
- Partials 25 28 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
The 'samples_per_trace' and 'sample_interval' fields were removed from `src/segy/config.py`. These fields are no longer needed and their removal simplifies the configuration handling.
Rework the logic for inferring the endianness and revision of SEG-Y files, introducing explicit handling for different cases and additional settings-based overrides. This update simplifies control flow and improves the clarity and maintainability of the code.
Extract spec initialization into a separate method `_initialize_spec` to simplify the code structure and improve readability. This refactoring ensures centralized logic for setting the SEG-Y standard and endianness, reducing redundancy and potential errors.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.