Fix bug in decoding IBM-float values in trace accessor #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #168
The TraceAccessor was constructing the wrong pipeline when IBM-float header keys were present. It was not decoding the IBM-float headers. The
SegyFile's.tracemethod was returning wrong values. However, the.headeraccessor works fine because the pipeline is correct.The fundamental issue is:
TransformandTransformPipelinehas no way to apply nested decoding transformations. As a workaround (without changing the fundamental design), I implemented aTraceTransform, which applies a trace's header and data transforms pipelines in sequence. This is terrible because it introduces a circular dependency:TransformPipelinedepends onTransforms, which depends onTransformPipelines. You can also see all the typing issues we had to ignore.This was a quick fix, but we must refactor the transformation logic to improve it. Will open a separate issue for it.