Skip to content

Nginx documentation and websocket support for Hedgedoc #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2021
Merged

Nginx documentation and websocket support for Hedgedoc #79

merged 3 commits into from
Oct 20, 2021

Conversation

@JJ-8
Copy link
Collaborator

@JJ-8 JJ-8 commented Oct 20, 2021

As discussed in #68.

B-i-t-K
B-i-t-K approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@B-i-t-K B-i-t-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XeR
Copy link
Contributor

XeR commented Oct 20, 2021

Hey ! Thanks for the pull request.
I'm not too fan of listening only on 127.0.0.1. I think small teams run CTFNote with docker-compose up -d and don't think about it anymore.
I'm afraid this will scare beginners since having to configure a front-end will make it harder for them (e.g. https://twitter.com/su_496/status/1329593171257348096#).
Ideally, we'd like to have it as plug-and-play as possible but still let the power-users make the changes they want.

+1 for port 8080

@XeR XeR merged commit 1936621 into TFNS:main Oct 20, 2021
JJ-8 added a commit that referenced this pull request Apr 28, 2024
@JJ-8
Merge pull request #79 from markfijneman/navbar-redesign
9f11920 
Navigation bar redesign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@B-i-t-K B-i-t-K B-i-t-K approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JJ-8 @XeR @B-i-t-K